PE section flags #23520
Closed
PE section flags #23520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trufae
reviewed
Oct 23, 2024
libr/include/r_bin.h
Outdated
| @@ -303,6 +303,7 @@ typedef struct r_bin_section_t { | |||
| ut64 vaddr; | |||
| ut64 paddr; | |||
| ut32 perm; | |||
| ut32 flags; | |||
There was a problem hiding this comment.
This change breaks the ABI so we can't merge this until the 5.9.8 release is out. we can have R2_USE_NEW_ABI ifdef if you want.. but personall i would wait because it shuoldnt be taking long and we can probably introduce this new field to work with other fileformats
There was a problem hiding this comment.
trufae
requested changes
Oct 23, 2024
|
can you rebase this pr and finish it? we are in the abi breaking season now :) |
trufae
reviewed
Nov 22, 2024
| (ut64)section->paddr, (ut64)section->size, | ||
| (ut64)addr, (ut64)section->vsize, | ||
| perms, stype, section_name); | ||
| perms, stype, section_name, section->flags); |
There was a problem hiding this comment.
i think this should be after before perms not after the name
sha0coder
force-pushed
the
pesectionflags
branch
from
fbe0758 to
d36cd2d
Compare
trufae
reviewed
Nov 23, 2024
| r_table_set_columnsf (table, "dXxXxssss", | ||
| "nth", "paddr", "size", "vaddr", "vsize", "perm", hashtypes, "type", "name"); | ||
| r_table_set_columnsf (table, "dXxXxssssx", | ||
| "nth", "paddr", "size", "vaddr", "vsize", "perm", hashtypes, "type", "name", "flags"); |
There was a problem hiding this comment.
Put flags before or after perm. But not after name
trufae
requested changes
Nov 23, 2024
|
fixed in #23699 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally the section->perm item is not necesary because can be infered from section->flags
both come from PE section Characteristics but perm is transformed in the way, we keep the orignal flags on flags item.