WIP: ASN.1 printings enhancements #23478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trufae
requested changes
Oct 15, 2024
| } | ||
|
|
||
| if (obj->tag == TAG_SEQUENCE || obj->tag == TAG_SET) { | ||
| r_strbuf_append (sb, "├─┬ "); |
There was a problem hiding this comment.
dont use utf8 unless scr.utf8 is set pls
|
ping |
0x8008135
force-pushed
the
asn1_printings
branch
from
9a9372e to
9f6f5ce
Compare
0x8008135
changed the title
0x8008135
force-pushed
the
asn1_printings
branch
from
700923b to
8f87a93
Compare
0x8008135
force-pushed
the
asn1_printings
branch
from
9b7fdef to
c7440e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims at enhancing the
pFacommand output with the following:Fix length miscalculation
Add header on
pFaoutput for better understandingChange the output format of some ASN.1 tags (hexstring), truncate to 100 characters if too long
Tree view using
pFat