-
-
Notifications
You must be signed in to change notification settings - Fork 98
Enclose scribble parts in an html section tag #520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Section tag class attribute is set to the level of the part and id attribute is set to 'section <the section number>'.
This has been only lightly tested. Volunteers welcome. I should add the new class names to the Scribble docs for the CSS classes. I don't see any place in the current documentation where it would be appropriate to document the format of the |
Oops, looks like I have some more work to do, some tests are failing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resyntax analyzed 1 file in this pull request and found no issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resyntax analyzed 1 file in this pull request and found no issues.
One thought/question: The CSS class name associated with a |
@mflatt that's a good point. How might I implement relative levels, just subtract Since the class is purely for page layout, not sematics, it makes sense to me to just have relative levels. |
Enhance the Scribble html renderer to enclose the
@title
,@section
,@subsection
, etc parts in an html<section>
tag. This enables better support for assistive technologies, and some CSS layout strategies such as a "block-based" design. For the latter, see Shriram Krishnamurthi's thread on the Racket Discord.The section tag
class
attribute is set to the level of the part in the ofSsectionLevel<n>
, and theid
attribute is set tosection <the section number>
. Theid
attribute is necessary for "block-based" design.