Downgrade fatal error to a warning in the case of missing LLDP info

rackerlabs · Oct 22, 2024 · 667249d · 667249d
1 parent 0c296e5
commit 667249d
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/python/understack-workflows/understack_workflows/bmc_chassis_info.py b/python/understack-workflows/understack_workflows/bmc_chassis_info.py
@@ -6,8 +6,9 @@
 
 from understack_workflows.bmc import Bmc
 from understack_workflows.interface_normalization import normalize_interface_name
+from understack_workflows.helpers import setup_logger
 
-urllib3.disable_warnings(urllib3.exceptions.InsecureRequestWarning)
+logger = setup_logger(__name__)
 
 
 @dataclass(frozen=True)
@@ -65,7 +66,11 @@ def interface_data(bmc: Bmc) -> list[InterfaceInfo]:
 
 def combine_lldp(lldp, interface) -> InterfaceInfo:
     name = interface["name"]
-    lldp_entry = lldp[name]
+    lldp_entry = lldp.get(name, {})
+    if not lldp_entry:
+        logger.info(
+            f"LLDP info from BMC is missing for {name}, we only have {list(lldp.keys())}"
+        )
     return InterfaceInfo(**interface, **lldp_entry)