dialyzer warnings rabbit v3.11.x

.bazelignore

@@ -1 +1,6 @@
-/.erlang.mk/
+# .bazelignore behaves differently than .gitignore
+# https://github.com/bazelbuild/bazel/issues/7093
+.erlang.mk
+deps/osiris
+deps/ra
+extra_deps

.bazelrc

@@ -1,9 +1,13 @@
-build --experimental_enable_bzlmod
-build --registry=https://raw.githubusercontent.com/rabbitmq/bazel-central-registry/dev/
+build --enable_bzlmod
 
 build --incompatible_strict_action_env
 build --local_test_jobs=1
 
+build --flag_alias=erlang_home=@rules_erlang//:erlang_home
+build --flag_alias=erlang_version=@rules_erlang//:erlang_version
+build --flag_alias=elixir_home=//:elixir_home
+build --flag_alias=test_build=//:enable_test_build
+
 build:buildbuddy --bes_results_url=https://app.buildbuddy.io/invocation/
 build:buildbuddy --bes_backend=grpcs://remote.buildbuddy.io
 build:buildbuddy --remote_cache=grpcs://remote.buildbuddy.io
@@ -14,6 +18,12 @@ build:buildbuddy --remote_download_minimal
 build:buildbuddy --build_metadata=REPO_URL=https://github.com/rabbitmq/rabbitmq-server.git
 build:buildbuddy --experimental_remote_cache_compression
 build:buildbuddy --experimental_remote_cache_async
+build:buildbuddy --noslim_profile
+build:buildbuddy --experimental_profile_include_target_label
+build:buildbuddy --experimental_profile_include_primary_output
+
+# buildbuddy implies remote cache, so ct_logdir is restored to its default for reproducibility
+build:buildbuddy --@rules_erlang//:ct_logdir=
 
 build:rbe --config=buildbuddy
 
@@ -26,25 +36,32 @@ build:rbe --jobs=50
 build:rbe --crosstool_top=@rbe//cc:toolchain
 build:rbe --extra_toolchains=@rbe//config:cc-toolchain
 
-build:rbe --host_platform=@rbe//config:platform
+build:rbe --host_platform=//bazel/platforms:erlang_internal_platform
 
 build:rbe --host_cpu=k8
 build:rbe --cpu=k8
 
-build:rbe-23 --config=rbe
-build:rbe-23 --platforms=//bazel/platforms:erlang_23_platform
-build:rbe-23 --extra_execution_platforms=//bazel/platforms:erlang_23_platform
-
 build:rbe-24 --config=rbe
-build:rbe-24 --platforms=//bazel/platforms:erlang_24_platform
-build:rbe-24 --extra_execution_platforms=//bazel/platforms:erlang_24_platform
+build:rbe-24 --platforms=//bazel/platforms:erlang_linux_24_platform
 
 build:rbe-25 --config=rbe
-build:rbe-25 --platforms=//bazel/platforms:erlang_25_platform
-build:rbe-25 --extra_execution_platforms=//bazel/platforms:erlang_25_platform
+build:rbe-25 --platforms=//bazel/platforms:erlang_linux_25_2_platform
+
+build:rbe-25_0 --config=rbe
+build:rbe-25_0 --platforms=//bazel/platforms:erlang_linux_25_0_platform
+
+build:rbe-25_1 --config=rbe
+build:rbe-25_1 --platforms=//bazel/platforms:erlang_linux_25_1_platform
+
+build:rbe-25_2 --config=rbe
+build:rbe-25_2 --platforms=//bazel/platforms:erlang_linux_25_2_platform
+
+# no-op config so that --config=local does not error
+build:local --color=auto
 
-build:local --platforms=//bazel/platforms:erlang_external_platform
-build:local --extra_execution_platforms=//bazel/platforms:erlang_external_platform
+# having bzlmod enabled seems to interfere with docker toolchain resolution,
+# so we set this flag
+build --@io_bazel_rules_docker//transitions:enable=false
 
 # Try importing a user specific .bazelrc
 # You can create your own by copying and editing the template-user.bazelrc template:

.github/ISSUE_TEMPLATE.md

@@ -14,7 +14,7 @@ cause analysis and so on.
 Please take the time to read the CONTRIBUTING.md document for instructions on
 how to effectively ask a question or report a suspected issue:
 
-https://github.com/rabbitmq/rabbitmq-server/blob/master/CONTRIBUTING.md#github-issues
+https://github.com/rabbitmq/rabbitmq-server/blob/main/CONTRIBUTING.md#github-issues
 
 Following these rules **will save time** for both you and RabbitMQ's maintainers.
 

.github/dependabot.yaml

@@ -5,7 +5,7 @@ updates:
     directory: "/"
     schedule:
       interval: "daily"
-    target-branch: "master"
+    target-branch: "main"
     labels:
       - backport-v3.11.x
       - backport-v3.10.x

.github/mergify.yml

@@ -15,7 +15,7 @@ pull_request_rules:
           - make
   - name: Automatically backport to v3.11.x based on label
     conditions:
-      - base=master
+      - base=main
       - label=backport-v3.11.x
       - label!=backport-v3.10.x
       - label!=backport-v3.9.x
@@ -28,7 +28,7 @@ pull_request_rules:
           - "{{ author }}"
   - name: Automatically backport to v3.11.x & v3.10.x based on label
     conditions:
-      - base=master
+      - base=main
       - label=backport-v3.11.x
       - label=backport-v3.10.x
       - label!=backport-v3.9.x
@@ -43,7 +43,7 @@ pull_request_rules:
           - "{{ author }}"
   - name: Automatically backport to v3.11.x, v3.10.x & v3.9.x based on labels
     conditions:
-      - base=master
+      - base=main
       - label=backport-v3.11.x
       - label=backport-v3.10.x
       - label=backport-v3.9.x
@@ -59,7 +59,7 @@ pull_request_rules:
           - "{{ author }}"
   - name: Automatically backport to v3.11.x, v3.10.x, v3.9.x & v3.8.x based on labels
     conditions:
-      - base=master
+      - base=main
       - label=backport-v3.11.x
       - label=backport-v3.10.x
       - label=backport-v3.9.x

.github/workflows/oci-base.yaml

@@ -6,16 +6,16 @@ on:
   workflow_dispatch:
 jobs:
   build-publish:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-20.04
     steps:
       - name: Checkout
         uses: actions/checkout@v3
 
       - name: Set up Docker Buildx
-        uses: docker/setup-buildx-action@v1
+        uses: docker/setup-buildx-action@v2
 
       - name: Cache Docker layers
-        uses: actions/cache@v3.0.5
+        uses: actions/cache@v3.2.3
         with:
           path: /tmp/.buildx-cache
           key: ${{ runner.os }}-${{ matrix.image_tag_suffix }}-buildx-${{ github.event.pull_request.head.sha || github.sha }}
@@ -33,13 +33,13 @@ jobs:
 
       - name: Login to DockerHub
         if: steps.authorized.outputs.PUSH == 'true'
-        uses: docker/login-action@v1
+        uses: docker/login-action@v2
         with:
           username: ${{ secrets.DOCKERHUB_USERNAME }}
           password: ${{ secrets.DOCKERHUB_PASSWORD }}
 
       - name: Build and push
-        uses: docker/build-push-action@v2
+        uses: docker/build-push-action@v3
         with:
           context: packaging/base-image
           pull: true

.github/workflows/oci.yaml

@@ -17,32 +17,34 @@ jobs:
   # This job will build one docker image per supported Erlang major version.
   # Each image will have two tags (one containing the Git commit SHA, one containing the branch name).
   #
-  # For example, for Git commit SHA '111aaa' and branch name 'main' and maximum supported Erlang major version '24',
+  # For example, for Git commit SHA '111aaa' and branch name 'main' and maximum supported Erlang major version '26',
   # the following tags will be pushed to Dockerhub:
   #
-  # * 111aaa-otp-min (image OTP 23)
-  # * main-otp-min (image OTP 23)
-  # * 111aaa-otp-max (image OTP 24)
-  # * main-otp-max (image OTP 24)
+  # * 111aaa-otp-min (image OTP 25)
+  # * main-otp-min (image OTP 25)
+  # * 111aaa-otp-max (image OTP 26)
+  # * main-otp-max (image OTP 26)
 
-  build-publish-dev:
-    runs-on: ubuntu-latest
+  build-publish-dev-bazel:
+    runs-on: ubuntu-20.04
     strategy:
       fail-fast: false
       matrix:
-          # Build image for every supported Erlang major version.
-          # Source of truth for OTP versions (min & max): https://www.rabbitmq.com/which-erlang.html
-          include:
-          - image_tag_suffix: otp-min
-            otp_major: 24
-          - image_tag_suffix: otp-max
-            otp_major: 25
+        include:
+          - image_tag_suffix: otp-min-bazel
+            otp_version_id: 25_0
+          - image_tag_suffix: otp-max-bazel
+            otp_version_id: 25_2
     steps:
       - name: Checkout
         uses: actions/checkout@v3
 
+      - name: Inject RabbitMQ Version
+        run: |
+          sed -i"_orig" -E '/APP_VERSION/ s/3\.[0-9]+\.[0-9]+/${{ github.event.pull_request.head.sha || github.sha }}/' rabbitmq.bzl
+
       - name: Mount Bazel Cache
-        uses: actions/cache@v3.0.5
+        uses: actions/cache@v3.2.3
         with:
           path: "/home/runner/repo-cache/"
           key: repo-cache
@@ -62,91 +64,74 @@ jobs:
             build:buildbuddy --disk_cache=
 
             build:buildbuddy --remote_download_toplevel
+
+            build --@io_bazel_rules_docker//transitions:enable=false
           EOF
 
-      - name: Load version info
+      - name: Check OTP/Elixir versions used in RBE
         id: load-info
         run: |
-          bazelisk build :otp_version --config=rbe-${{ matrix.otp_major }}
-          echo "::set-output name=otp::$(cat bazel-bin/otp_version.txt)"
+          bazelisk build :otp_version :elixir_version \
+            --config=rbe \
+            --platforms=//bazel/platforms:erlang_linux_${{ matrix.otp_version_id }}_platform
+          echo "otp=$(cat bazel-bin/otp_version.txt)" >> $GITHUB_OUTPUT
+          echo "elixir=$(cat bazel-bin/elixir_version.txt)" >> $GITHUB_OUTPUT
+
+      - name: Configure OTP & Elixir
+        uses: erlef/[email protected]
+        with:
+          otp-version: ${{ steps.load-info.outputs.otp }}
+          elixir-version: ${{ steps.load-info.outputs.elixir }}
 
-      - name: Build generic unix package
+      - name: Configure otp for the OCI image
         run: |
-          sed -i"_orig" -E '/APP_VERSION/ s/3\.[0-9]+\.[0-9]+/${{ github.event.pull_request.head.sha || github.sha }}/' rabbitmq.bzl
-          bazelisk build :package-generic-unix \
-            --config=rbe-${{ matrix.otp_major }}
+          sudo npm install --global --silent @bazel/buildozer
 
-      - name: Resolve generic unix package path
-        run: |
-          echo "::set-output name=ARTIFACT_PATH::$(readlink -f ${GENERIC_UNIX_ARCHIVE})"
-        id: resolve-artifact-path
+          buildozer 'set tars ["@otp_src_${{ matrix.otp_version_id }}//file"]' \
+            //packaging/docker-image:otp_source
 
-      - name: Save the package as a workflow artifact
-        uses: actions/upload-artifact@v3
-        with:
-          name: package-generic-unix-${{ steps.load-info.outputs.otp }}.tar.xz
-          path: ${{ steps.resolve-artifact-path.outputs.ARTIFACT_PATH }}
+      - name: Build
+        run: |
+          bazelisk build //packaging/docker-image:rabbitmq \
+            --config=buildbuddy
 
-      - name: Set up Docker Buildx
-        uses: docker/setup-buildx-action@v1
+      - name: Test
+        run: |
+          OCI_TESTS=$(bazel query 'tests(//packaging/docker-image/...)')
+          bazelisk test ${OCI_TESTS} \
+            --config=buildbuddy
 
-      - name: Cache Docker layers
-        uses: actions/[email protected]
-        with:
-          path: /tmp/.buildx-cache
-          key: ${{ runner.os }}-${{ matrix.image_tag_suffix }}-buildx-${{ github.event.pull_request.head.sha || github.sha }}
-          restore-keys: |
-            ${{ runner.os }}-${{ matrix.image_tag_suffix }}-buildx-
+      - name: Load
+        run: |
+          bazelisk run //packaging/docker-image:rabbitmq \
+            --config=buildbuddy
 
       - name: Check for Push Credentials
         id: authorized
         run: |
           if [ -n "${{ secrets.DOCKERHUB_USERNAME }}" ]; then
-            echo "::set-output name=PUSH::true"
+            echo "PUSH=true" >> $GITHUB_OUTPUT
           else
-            echo "::set-output name=PUSH::false"
+            echo "PUSH=false" >> $GITHUB_OUTPUT
           fi
 
       - name: Login to DockerHub
         if: steps.authorized.outputs.PUSH == 'true'
-        uses: docker/login-action@v1
+        uses: docker/login-action@v2
         with:
           username: ${{ secrets.DOCKERHUB_USERNAME }}
           password: ${{ secrets.DOCKERHUB_PASSWORD }}
 
-      - name: Expand generic-unix-package
-        working-directory: packaging/docker-image
+      - name: Tag and Push
+        if: steps.authorized.outputs.PUSH == 'true'
         run: |
-          xzcat ${{ steps.resolve-artifact-path.outputs.ARTIFACT_PATH }} | tar xvf -
+          TAG_1="${{ github.event.pull_request.head.sha || github.sha }}-${{ matrix.image_tag_suffix }}"
+          TAG_2="${GITHUB_REF##*/}-${{ matrix.image_tag_suffix }}"
 
-      - name: Compute image tags
-        id: compute-tags
-        run: |
-          echo "::set-output name=TAG_1::${{ github.event.pull_request.head.sha || github.sha }}-${{ matrix.image_tag_suffix }}"
-          echo "::set-output name=TAG_2::${GITHUB_REF##*/}-${{ matrix.image_tag_suffix }}"
+          docker tag bazel/packaging/docker-image:rabbitmq \
+            pivotalrabbitmq/rabbitmq:${TAG_1}
+          docker tag bazel/packaging/docker-image:rabbitmq \
+            pivotalrabbitmq/rabbitmq:${TAG_2}
 
-      - name: Build and push
-        uses: docker/build-push-action@v2
-        with:
-          context: packaging/docker-image
-          pull: true
-          push: ${{ steps.authorized.outputs.PUSH }}
-          tags: |
-            pivotalrabbitmq/rabbitmq:${{ steps.compute-tags.outputs.TAG_1 }}
-            pivotalrabbitmq/rabbitmq:${{ steps.compute-tags.outputs.TAG_2 }}
-          build-args: |
-            SKIP_PGP_VERIFY=true
-            PGP_KEYSERVER=pgpkeys.eu
-            OTP_VERSION=${{ steps.load-info.outputs.otp }}
-            SKIP_OTP_VERIFY=true
-            RABBITMQ_BUILD=rabbitmq_server-${{ github.event.pull_request.head.sha || github.sha }}
-          cache-from: type=local,src=/tmp/.buildx-cache
-          cache-to: type=local,dest=/tmp/.buildx-cache-new
-
-      # Temp fix
-      # https://github.com/docker/build-push-action/issues/252
-      # https://github.com/moby/buildkit/issues/1896
-      - name: Move cache
-        run: |
-          rm -rf /tmp/.buildx-cache
-          mv /tmp/.buildx-cache-new /tmp/.buildx-cache
+          docker push pivotalrabbitmq/rabbitmq:${TAG_1}
+          docker push pivotalrabbitmq/rabbitmq:${TAG_2}