Use siane version to avoid potential issues #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dieghernan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hola @hmeleiro:
He visto que en la viñeta de infoelectoral usas mapSpain para extraer los polígonos de los municipios a una fecha dada.
El riesgo es veo es que al usar
year = "2016"se fuerza una descarga a través de giscoR. Esta descarga es bastante pesada (>100Mb) porque tiene todos los municipios de la UE (mapSpain luego filtra solo los de España) y además en el pasado ha habido problemas con el acceso a GISCO por cambios en el servidor de la API (rOpenGov/giscoR#74, rOpenGov/giscoR#69 y varios más).Al incluirla en la viñeta, que CRAN ejecuta regularmente, veo cierto riesgo de que en un momento dado la viñeta dé problemas y tengas algún email de aviso desde CRAN por ERROR.
Este PR cambia
esp_get_munic()poresp_get_munic_siane(), que descarga la información equivalente pero proporcionada por el IGN solo para España, y es mucho más ligera (5Mb). Los resultados son los mismos y esta función jamás me ha dado problemas.Saludos.