Skip to content

Conversation

@DavisVaughan
Copy link
Member

@DavisVaughan DavisVaughan commented Nov 13, 2025

Goes with r-lib/slider#224, but doesn't require it

The actual implementation of this was right

void exp_short_init_compact_seq(int* p, R_len_t start, R_len_t size, bool increasing) {
  init_compact_seq(p, start, size, increasing);
}

but the signature here in vctrs was wrong. And then we copied over that wrong signature into slider as well.

Luckily because it returns void and we never look at the return value, it was fine. But CRAN picked up on it in one of their checks awhile back.

@DavisVaughan DavisVaughan merged commit 9a80368 into main Nov 14, 2025
13 checks passed
@DavisVaughan DavisVaughan deleted the fix/init-compact-seq-signature branch November 14, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants