Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused $._newline #158

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

DavisVaughan
Copy link
Member

Closes #156

We are always inside a (, [, or [[ scope when processing argument values, so newlines are consumed automatically by the external scanner.

I took a close look and this seems to be the only extraneous $._newline. All others are outside the (, [, or [[ scopes.

We are always inside a `(`, `[`, or `[[` scope when processing argument values, so newlines are consumed automatically by the external scanner.
@DavisVaughan DavisVaughan force-pushed the feature/remove-newline branch from cee276e to 4a94bf5 Compare November 22, 2024 20:02
@DavisVaughan DavisVaughan merged commit a0d3e33 into r-lib:main Nov 22, 2024
10 of 11 checks passed
@DavisVaughan DavisVaughan deleted the feature/remove-newline branch November 22, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Try removing this _newline in _argument_value
1 participant