Skip to content

multiple result sets: handle mixed success #927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 8, 2025
Merged

multiple result sets: handle mixed success #927

merged 3 commits into from
Jul 8, 2025

Conversation

detule
Copy link
Collaborator

@detule detule commented Jun 29, 2025 •
edited
Loading

Closes #924

When examining the result we try and check for two things:

  • Whether the current result set has more rows.
  • Whether there are more result sets.

With these changes, we are hopefully making these "queries" more robustly.

@detule detule requested a review from simonpcouch June 29, 2025 18:12
simonpcouch
simonpcouch approved these changes Jun 30, 2025
View reviewed changes
Copy link
Collaborator

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this seems reasonable! May need a NEWS entry.

@detule detule merged commit 55ce07e into r-dbi:main Jul 8, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonpcouch simonpcouch simonpcouch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failure to return SELECT query depending on params order
2 participants
@detule @simonpcouch