Merged
Conversation
upstream: nanodbc/nanodbc#259 nanodbc: missing convert wide to * nanodbc: fixup sqldescribeparam
simonpcouch
approved these changes
Mar 3, 2025
Collaborator
simonpcouch
left a comment
simonpcouch
left a comment
There was a problem hiding this comment.
Thanks for the upstream ref. Looks good—thank you!
| // 888 Y8P 888 "888 "888 888 Y8b 888 888 888888 888 Y88o88P 888 | ||
| // 888 " 888 Y88b d88P Y88b d88P Y88b.Y8b88P 888 888 Y888P 888 | ||
| // 888 888 "Y8888P" "Y8888P" "Y888888" 88888888 888 Y8P 888 | ||
| // Y8b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi:
This catches up our vendored nanodbc lib to upstream in terms of TVP functionality. Not part of this PR:
On the last two I will prepare a new PR; the diff on this one alone ended up being large enough that I thought breaking it out might make sense in terms of being able to better attribute any changes in existing behavior ( hopefully none! ).
Compare upstream: nanodbc/nanodbc#259