Skip to content

Conversation

kba
Copy link
Contributor

@kba kba commented Sep 29, 2025

This merges the unifying-training-models branch of https://github.com/qurator-spk/sbb_pixelwise_segmentation into the folder train, so we have everything needed for running and training eynollah's components in a single place.

I did the merge with:

cd ../sbb_pixelwise_segmentation
git filter-repo --force --to-subdirectory-filter train
cd ../eynollah
git add remote train ../sbb_pixelwise_segmentation
git merge --allow-unrelated-histories -m "Merge sbb_pixelwise_segmentation training code into eynollah" train/unifying-training-models

So, all the commits of sbb_pixelwise_segmentation are included in eynollah's git history now.

I struggled with the documentation, though. The documentation on training models was in different states in three places AFAICS: sbb_pixelwise_segmentation.wiki, train.md in sbb_pixelwise_segmentation and in docs/train.md in eynollah. I did align the texts syntactically to compare and decided that docs/train.md is the most up-to-date version, so I removed the others. While resolving the train.md version, I also added the eynollah wiki page documenting (an earlier stage of) eynollah (layout) as docs/eynollah_layout.md. Unless there are good reasons against, I would recommend closing that wiki and keeping all documentation in /docs.

Once we merge here, I would:

@cneud
Copy link
Member

cneud commented Sep 29, 2025

all the commits of sbb_pixelwise_segmentation are included in eynollah's git history now

Perfect!

decided that docs/train.md is the most up-to-date version, so I removed the others

Correct. eynollah/docs/train.md supersedes all other versions and wikis.

I also added the eynollah wiki page documenting (an earlier stage of) eynollah (layout) as docs/eynollah_layout.md

This is already part of /docs, separated into eynollah/docs/models.md and eynollah/docs/usage.md.

The intention was to make the main README.md shorter and cleaner and separate more specific documentation into their own Markdown files - and stop using the Wiki but include all relevant docs as part of the codebase.

I would recommend closing that wiki and keeping all documentation in /docs.

👍

Copy link
Member

@cneud cneud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good to go now, thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants