Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strided tiles (RFC) #46

Open
xalexalex opened this issue Nov 12, 2023 · 2 comments
Open

strided tiles (RFC) #46

xalexalex opened this issue Nov 12, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@xalexalex
Copy link

Simply a request for comments.

In my experience I often find strided inference (i.e. overlapping tiles) to be more informative than inference on a grid of non-overlapping tiles, like WSInfer and its qupath extension currently do. This could be not-too-hard to implement in the wsinfer window.

I don't know if this requires changes on the WSInfer backend (I think not), however I have no idea how QuPath handles overlapping detections.

@kaczmarj
Copy link
Collaborator

i think adding this is a great idea overlapping tiles could give us smoother heatmaps and maybe would smooth out some noisy classifications.

this would require a change in this repo (for the qupath extension) and in the wsinfer python repo (i opened SBU-BMI/wsinfer#202 to track this).

i'm not sure how to structure the outputs of overlapping tiles. would we do any sort of averaging across overlaps? or would we use the small non-overlapping regions and make those the patches that we visualize?

@kaczmarj kaczmarj added the enhancement New feature or request label Nov 12, 2023
@petebankhead
Copy link
Member

This should already be possible in QuPath if you generate the tiles with Analyze → Tiles & superpixels → Create tiles.

There is some more information here. The 'select tiles' option is there to make the command really flexible.

I don't know if this requires changes on the WSInfer backend (I think not), however I have no idea how QuPath handles overlapping detections.

When using the QuPath extension there isn't really a WSInfer backend. The QuPath WSInfer extension only uses WSInfer models & specification - all the code in the extension is specific to QuPath, using PyTorch via Deep Java Library (but not involving Python at all).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants