generated from qupath/qupath-extension-template
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement model versioning #113
Draft
alanocallaghan
wants to merge
13
commits into
qupath:main
Choose a base branch
from
alanocallaghan:versioning
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on-instanseg into versioning
…on-instanseg into versioning
Suggest that the delim for name and version should be either another / or : |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
version
field for the InstanSegModel class.model_name
(from the rdf yaml), and versions in a subdirectory (eg0.0.1
)local/my_model-0.1.0
. Can mismatch for local models but that's fine.my_model-0.0.1
.Downloading works as before, where we download zips on request and hopefully don't do anything twice, but still check for validity etc. This would work without needing to remove previous model versions, although you would get a weird structure where
brightfield_nuclei/
contains0.0.1
and0.0.2
model directories, but also the files from the original 0.0.1 download.Currently, this is implemented with the releases on my fork. There is a minor mismatch in that the rdf version is "0.0.1" while the release name is "v0.0.1", but this is easily fixable.
Also, log some more errors.