Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min method to size interface #15

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Add min method to size interface #15

merged 1 commit into from
Feb 5, 2025

Conversation

alanocallaghan
Copy link
Contributor

@alanocallaghan alanocallaghan commented Feb 5, 2025

Our use of Shape and Size objects relies heavily on these having a min; each of the size classes has a fairly well-defined min, therefore rather than relying on calling code to check the shape or target shape, it is easier for us to add a min to the Size interface and propagate calls from Shape down to the individual Size objects if necessary (eg, in an 0.5 object).

Also convert FixedSize to a record.

@alanocallaghan alanocallaghan force-pushed the min-size branch 2 times, most recently from ee72414 to fee887a Compare February 5, 2025 11:16
@alanocallaghan alanocallaghan merged commit 7578c59 into main Feb 5, 2025
1 check passed
@alanocallaghan alanocallaghan deleted the min-size branch February 5, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant