Add support for Tips mod on ProgressScreen #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds optional support to the Tips mod by adding
ProgressScreento the list of screens that tips can render on.This was originally reported in Darkhax-Minecraft/Tips#62, which led me to add to Tips' API the ability for mods to add modded screens to the renderable list Darkhax-Minecraft/Tips#88.
Before this PR (Source: Darkhax-Minecraft/Tips#62):
After this PR:
(Note: I think the weird rendering of the underline and lack of a percentage sign is due to the hacky way I forced the game to display this screen to test it. I didn't change anything in the
ProgressScreenclass, so it shouldn't be actually affected.)I tried my best to make this PR fit in with the rest of the code base, but because I'm not familiar with BCLib I'm sure I made some mistakes when it comes to code style. Please let me know if you would like me to change anything :)