proto: pacer slow mode #2323
proto: pacer slow mode #2323
Conversation
vitocln
force-pushed
the
feat/slow-mode-pacer
branch
from
a20b423 to
694cbd8
Compare
| @@ -18,18 +18,20 @@ pub(super) struct Pacer { | |||
| last_mtu: u16, | |||
| tokens: u64, | |||
| prev: Instant, | |||
| burst_mode: bool, | |||
There was a problem hiding this comment.
Does this need to be stateful? Would it be sufficient to instead just clamp the maximum delay returned?
There was a problem hiding this comment.
That was the first approach I tried, but it didn’t resolve the issue. If the pacer gets stalled for an extended period—e.g., due to the congestion window—it accumulates tokens up to the cap (minimum 10 packets), which then results in a burst when it resumes sending.
Do you have a better idea?
There was a problem hiding this comment.
Hmm, I see how that would be a problem. I'll need to find time to think on this more. In the mean time, please add unit tests that validate the new behavior, both in steady state and after an idle period as you outlined above.
|
Could we make this more dynamic instead of using a boolean burst mode? |
The pacer enters dynamically in slow mode when the inter-packet pacing exceed 10 ms. In slow mode, the pacer sends only single packet per interval and disables the default burst sending mode.
vitocln
force-pushed
the
feat/slow-mode-pacer
branch
from
694cbd8 to
43c7728
Compare
Linked to this issue.
The pacer enters dynamically in slow mode when the inter-packet pacing exceed 10 ms. In slow mode, the pacer sends only single packet per interval and disables the default burst sending mode.