Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(.github/codecov): Install golang for fips codecov #2023

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dongcarl
Copy link

@dongcarl dongcarl commented Oct 29, 2024

An attempt to fix https://github.com/quinn-rs/quinn/actions/runs/11562272211/job/32183071070 on main and (unreleased) 0.5.6

@dongcarl
Copy link
Author

dongcarl commented Oct 29, 2024

It seems from the CI failure that code coverage builds for Windows for aws-lc-fips-sys is more complicated than expected.

More resources:

@mxinden @Ralith @djc I guess a decision has to be made if full coverage for aws-lc-fips-sys is worth the build system troubles

Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What goal are you trying to achieve here?

@dongcarl
Copy link
Author

@djc
Copy link
Member

djc commented Nov 5, 2024

@mxinden @Ralith @djc I guess a decision has to be made if full coverage for aws-lc-fips-sys is worth the build system troubles

I think we should definitely fix it so coverage builds can succeed (I'm surprised the main CI failures don't generate any notifications for me...). I think rustls has this working so it shouldn't be too hard to fix?

https://github.com/rustls/rustls/blob/main/.github/workflows/build.yml#L51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants