Change CI trigger to just "push". Remove "venv". #3864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3864 +/- ##
===========================================
+ Coverage 35.40% 89.31% +53.90%
===========================================
Files 709 79 -630
Lines 31254 9995 -21259
Branches 4681 0 -4681
===========================================
- Hits 11066 8927 -2139
+ Misses 19032 1068 -17964
+ Partials 1156 0 -1156
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
These seem to be left over from CircleCI. Let's clean them up: - Any pull request involves pushing to some branch, so `push` is sufficient - Pushing a tag also triggers the workflow, so no need to handle those differently - CircleCI required virtual environments to be set up, but that's not the case anymore, so there's no `./venv`
sir-sigurd
reviewed
Feb 7, 2024
| tags: | ||
| - "*" | ||
| pull_request: | ||
| merge_group: |
There was a problem hiding this comment.
sir-sigurd
reviewed
Feb 7, 2024
| - master | ||
| tags: | ||
| - "*" | ||
| pull_request: |
There was a problem hiding this comment.
I'm not sure it's really needed, but #3001
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of that seems to be left over from Circle CI.