Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Open in desktop" button, also added button for the file view #3792

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Nov 17, 2023

demo-2023-11-17_11.37.38.mp4

@fiskus fiskus changed the title Open in desktop button, also added button for the file view "Open in desktop" button, also added button for the file view Nov 17, 2023
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 57 lines in your changes are missing coverage. Please review.

Comparison is base (6156b1b) 34.71% compared to head (31ef6ae) 34.69%.

Files Patch % Lines
.../app/containers/Bucket/PackageTree/PackageTree.tsx 0.00% 49 Missing ⚠️
...log/app/containers/OpenInDesktop/OpenInDesktop.tsx 0.00% 4 Missing ⚠️
...app/containers/Bucket/PackageTree/RevisionMenu.tsx 0.00% 2 Missing ⚠️
catalog/app/utils/TeleportUri.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3792      +/-   ##
==========================================
- Coverage   34.71%   34.69%   -0.02%     
==========================================
  Files         709      709              
  Lines       31062    31078      +16     
  Branches     4638     4639       +1     
==========================================
  Hits        10784    10784              
- Misses      19129    19147      +18     
+ Partials     1149     1147       -2     
Flag Coverage Δ
api-python 91.22% <ø> (ø)
catalog 9.24% <0.00%> (-0.01%) ⬇️
lambda 86.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant