Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3ObjectLocation, Package.Handle, Package.Hash types refactoring #3681

Open
wants to merge 37 commits into
base: master
Choose a base branch
from

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Aug 9, 2023

Attempt to consistently use:

  • { bucket, key, version? }{ location: S3.S3ObjectLocation }
  • { bucket, name }{ handle: Package.Handle }
  • { hash }{ hash: Package.Hash }
  • { hashOrTag } -> { revision: Package.Hash | Package.HashAlias }, and functions hashOrTag() and tagOrHash()

https://github.com/quiltdata/specs/pull/53 for context

@akarve akarve requested a review from nl0 August 14, 2023 17:53
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #3681 (e26ca15) into master (683809b) will increase coverage by 0.01%.
The diff coverage is 1.29%.

@@            Coverage Diff             @@
##           master    #3681      +/-   ##
==========================================
+ Coverage   36.21%   36.22%   +0.01%     
==========================================
  Files         677      678       +1     
  Lines       29720    29711       -9     
  Branches     4327     4314      -13     
==========================================
  Hits        10763    10763              
+ Misses      17825    17816       -9     
  Partials     1132     1132              
Flag Coverage Δ
api-python 91.35% <ø> (ø)
catalog 9.84% <1.29%> (+<0.01%) ⬆️
lambda 86.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
catalog/app/components/FileEditor/CreateFile.tsx 0.00% <0.00%> (ø)
.../FileEditor/QuiltConfigEditor/WorkflowsToolbar.tsx 0.00% <0.00%> (ø)
catalog/app/components/FileEditor/State.tsx 0.00% <0.00%> (ø)
catalog/app/components/JsonDisplay/JsonDisplay.js 0.00% <0.00%> (ø)
...talog/app/components/Preview/loaders/Html/Html.tsx 0.00% <0.00%> (ø)
catalog/app/components/Preview/loaders/Markdown.js 29.68% <0.00%> (+0.45%) ⬆️
...og/app/components/Preview/loaders/NamedPackage.tsx 0.00% <ø> (ø)
...atalog/app/components/Preview/loaders/Notebook.tsx 0.00% <0.00%> (ø)
catalog/app/components/Preview/loaders/Voila.ts 0.00% <0.00%> (ø)
.../app/components/Preview/renderers/NamedPackage.tsx 0.00% <ø> (ø)
... and 47 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fiskus fiskus mentioned this pull request Aug 22, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant