Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide .quilt directory #3634

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

Hide .quilt directory #3634

wants to merge 12 commits into from

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Jul 27, 2023

Added preferences.blocks.browser.hidden property to show hidden files. Probably, it is confusing, and is better to use showHidden. Or maybe it's ok in context of entire config where true shows and false hides

Also, memoized Listing in PackageTree

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #3634 (9f5d111) into master (4933ee3) will decrease coverage by 0.02%.
The diff coverage is 9.83%.

@@            Coverage Diff             @@
##           master    #3634      +/-   ##
==========================================
- Coverage   36.14%   36.12%   -0.02%     
==========================================
  Files         676      676              
  Lines       29673    29701      +28     
  Branches     4321     4328       +7     
==========================================
+ Hits        10724    10729       +5     
- Misses      17812    17835      +23     
  Partials     1137     1137              
Flag Coverage Δ
api-python 91.35% <ø> (ø)
catalog 9.84% <9.83%> (+0.01%) ⬆️
lambda 86.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
catalog/app/containers/Bucket/Dir.tsx 0.00% <0.00%> (ø)
catalog/app/containers/Bucket/Listing.tsx 0.00% <0.00%> (ø)
...p/containers/Bucket/PackageDialog/S3FilePicker.tsx 0.00% <0.00%> (ø)
.../app/containers/Bucket/PackageTree/PackageTree.tsx 0.00% <0.00%> (ø)
catalog/app/utils/BucketPreferences/index.ts 0.00% <0.00%> (ø)
...g/app/utils/BucketPreferences/BucketPreferences.ts 71.60% <85.71%> (+0.93%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fiskus fiskus marked this pull request as ready for review July 27, 2023 15:10
@fiskus fiskus requested a review from nl0 August 3, 2023 09:47
Copy link
Member

@nl0 nl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this should be a catalog-level option, not bucket-level. @akarve wdyt?

@fiskus fiskus marked this pull request as draft August 22, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants