-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropzone only package dialog #3405
base: master
Are you sure you want to change the base?
Conversation
…searh as source of truth
Codecov Report
@@ Coverage Diff @@
## master #3405 +/- ##
==========================================
- Coverage 36.22% 36.15% -0.07%
==========================================
Files 682 682
Lines 29787 29840 +53
Branches 4383 4401 +18
==========================================
- Hits 10790 10789 -1
- Misses 17841 17897 +56
+ Partials 1156 1154 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I'm going to decouple some changes to separate PRs for easier review |
|
…uilt into dropzone-only-package-dialog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, but there's a lot of changes and i can't fully digest them, so i just hope that works =)
catalog/app/containers/Bucket/PackageDialog/PackageCreationForm.tsx
Outdated
Show resolved
Hide resolved
catalog/app/containers/Bucket/PackageDialog/PackageCreationForm.tsx
Outdated
Show resolved
Hide resolved
|
||
Available parameters are | ||
|
||
* `createPackage=true` to open a package dialog, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'd prefer some shorter lowercase params like edit=
and dropzone=
, but i guess it would be more ambiguous, so whatever
catalog/app/containers/Bucket/PackageDialog/PackageCreationForm.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexei Mochalov <[email protected]>
…uilt into dropzone-only-package-dialog
Added:
dropZoneOnly
and change UI according to that - show only files dropzoneRefactored:
hashOrTag
insteadhash
where we could use hash or tagTODO