Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropzone only package dialog #3405

Draft
wants to merge 59 commits into
base: master
Choose a base branch
from
Draft

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Apr 10, 2023

Added:

  • Added dropZoneOnly and change UI according to that - show only files dropzone
  • Move dialog open state to URL

Refactored:

  • Move Create Package state to upper level using Provider pattern
  • Reduce state/setState management using Provider and URL state
  • Use hashOrTag instead hash where we could use hash or tag
  • Make Create Package dialog state dependent on URL only, so we can move it to the standalone page

TODO

  • Automated tests (e.g. Preflight)
  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

@fiskus fiskus marked this pull request as draft April 10, 2023 09:49
@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Merging #3405 (e53e4da) into master (d1df293) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3405      +/-   ##
==========================================
- Coverage   36.22%   36.15%   -0.07%     
==========================================
  Files         682      682              
  Lines       29787    29840      +53     
  Branches     4383     4401      +18     
==========================================
- Hits        10790    10789       -1     
- Misses      17841    17897      +56     
+ Partials     1156     1154       -2     
Flag Coverage Δ
api-python 91.29% <ø> (ø)
catalog 10.19% <0.00%> (-0.04%) ⬇️
lambda 86.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
catalog/app/containers/Bookmarks/Sidebar.tsx 0.00% <0.00%> (ø)
catalog/app/containers/Bucket/Dir.tsx 0.00% <0.00%> (ø)
...log/app/containers/Bucket/PackageDialog/Layout.tsx 0.00% <0.00%> (ø)
...iners/Bucket/PackageDialog/PackageCreationForm.tsx 0.00% <0.00%> (ø)
.../containers/Bucket/PackageDialog/PackageDialog.tsx 26.35% <ø> (+0.80%) ⬆️
...g/app/containers/Bucket/PackageDialog/Provider.tsx 0.00% <0.00%> (ø)
...g/app/containers/Bucket/PackageDialog/Skeleton.tsx 0.00% <0.00%> (ø)
...talog/app/containers/Bucket/PackageDialog/index.ts 0.00% <0.00%> (ø)
.../app/containers/Bucket/PackageList/PackageList.tsx 0.00% <0.00%> (ø)
...iners/Bucket/PackageRevisions/PackageRevisions.tsx 0.00% <0.00%> (ø)
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fiskus
Copy link
Member Author

fiskus commented Apr 19, 2023

I'm going to decouple some changes to separate PRs for easier review

@fiskus
Copy link
Member Author

fiskus commented Apr 19, 2023

hashhashOrTag: #3430

Copy link
Member

@nl0 nl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but there's a lot of changes and i can't fully digest them, so i just hope that works =)

catalog/app/containers/Bucket/Dir.tsx Show resolved Hide resolved
catalog/app/containers/Bucket/PackageDialog/Provider.tsx Outdated Show resolved Hide resolved

Available parameters are

* `createPackage=true` to open a package dialog,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd prefer some shorter lowercase params like edit= and dropzone=, but i guess it would be more ambiguous, so whatever

@fiskus fiskus marked this pull request as draft August 11, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants