Bump rdkafka to fix some issue with kafka 4.X.X and kraft #5841
+24
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot @nico34638! Did you test it on your environment? |
|
Yes, I tested it with an aws msk 4.0.0 kraft cluster and the connection works fine. |
|
Great. @rdettai can you review? |
rdettai
requested changes
Jul 15, 2025
There was a problem hiding this comment.
see clippy
error[E0308]: mismatched types
--> quickwit-indexing/src/source/kafka_source.rs:856:23
|
856 | .map(|(partition, offset)| (id, partition, offset))
| ^^^^^^^^^^^^^^^^^^^
| |
| expected `Delivery`, found `(_, _)`
| expected due to this
|
= note: expected struct `rdkafka::producer::future_producer::Delivery`
found tuple `(_, _)`
|
I've added a fix |
rdettai
reviewed
Jul 16, 2025
| @@ -853,7 +853,7 @@ mod kafka_broker_tests { | |||
| Duration::from_secs(1), | |||
| ) | |||
| .await | |||
| .map(|(partition, offset)| (id, partition, offset)) | |||
| .map(|delivery| (id, delivery.partition, delivery.offset)) | |||
There was a problem hiding this comment.
Now it's fmt that isn't happy because of the trailing space. You can run make fix as advised in the contribution guide to prevent these issues. Thanks!
|
I've added a fix, sorry |
rdettai
approved these changes
Jul 17, 2025
There was a problem hiding this comment.
I didn't test with various auth configurations, but integ tests work (see https://github.com/quickwit-oss/quickwit/actions/runs/16339696703/job/46159034682)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump rdkafka to fix some issue with kafka 4.X.X and kraft