Some sanity rewrite of the LocalSplitStore #5603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdettai
changed the base branch from
code-simplification-of-indexing-split-cache
to
main
rdettai
force-pushed
the
simplify-indexing-split-cache
branch
from
7cc66d3 to
7114b3d
Compare
rdettai
force-pushed
the
simplify-indexing-split-cache
branch
from
7114b3d to
ad63ee2
Compare
guilload
approved these changes
Jan 17, 2025
quickwit/quickwit-indexing/src/split_store/indexing_split_store.rs
Outdated
Show resolved
Hide resolved
quickwit/quickwit-indexing/src/split_store/indexing_split_cache.rs
Outdated
Show resolved
Hide resolved
quickwit/quickwit-indexing/src/split_store/indexing_split_cache.rs
Outdated
Show resolved
Hide resolved
quickwit/quickwit-indexing/src/split_store/indexing_split_cache.rs
Outdated
Show resolved
Hide resolved
quickwit/quickwit-indexing/src/split_store/indexing_split_cache.rs
Outdated
Show resolved
Hide resolved
quickwit/quickwit-indexing/src/split_store/indexing_split_cache.rs
Outdated
Show resolved
Hide resolved
quickwit/quickwit-indexing/src/split_store/indexing_split_cache.rs
Outdated
Show resolved
Hide resolved
quickwit/quickwit-indexing/src/split_store/indexing_split_cache.rs
Outdated
Show resolved
Hide resolved
quickwit/quickwit-indexing/src/split_store/indexing_split_cache.rs
Outdated
Show resolved
Hide resolved
guilload
reviewed
Jan 17, 2025
quickwit/quickwit-indexing/src/split_store/indexing_split_cache.rs
Outdated
Show resolved
Hide resolved
quickwit/quickwit-indexing/src/split_store/indexing_split_cache.rs
Outdated
Show resolved
Hide resolved
- Renaming `LocalSplitStore` -> `IndexingSplitCache`. - Removing of the useless BinaryHeap, HashMap, using instead a single BTreeMap - Isolating quota and BTreeMap to ensure their transactionality. - Logging eventual io errors.
rdettai
force-pushed
the
simplify-indexing-split-cache
branch
from
9b823a1 to
5e25f14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5591
Rework of #4275