Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use configLocation #116

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Use configLocation #116

wants to merge 3 commits into from

Conversation

katlim-br
Copy link

@katlim-br katlim-br commented Nov 29, 2024

Modify all places that has the node.yaml path hardcoded to refer to the configLocation value.

@rdettai
Copy link
Contributor

rdettai commented Dec 2, 2024

The Values.configLocation is a very confusing parameter. After reading the code, my understanding is that it works the following way:

  • if using the default value (/quickwit/node.yaml), the config that is mounted and used is the one defined inline in the Values.config
  • if setting the value to another file location, the config will be read from that file (Values.config always being mounted at /quickwit/node.yaml, it is never read).

I agree this isn't clear and should at least be documented, but I believe it's the intended behavior introduced in #92. @idrissneumann @hgudladona correct me if I'm wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants