Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid requiring atomics on quickjs-libc #613

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Avoid requiring atomics on quickjs-libc #613

merged 2 commits into from
Oct 22, 2024

Conversation

saghul
Copy link
Contributor

@saghul saghul commented Oct 22, 2024

No description provided.

@saghul
Copy link
Contributor Author

saghul commented Oct 22, 2024

@bnoordhuis PTAL, not sure if TSAN will be happy, let's see.

@saghul saghul mentioned this pull request Oct 22, 2024
Closed
@saghul
Copy link
Contributor Author

saghul commented Oct 22, 2024

TSan run: https://github.com/quickjs-ng/quickjs/actions/runs/11454131351

@saghul
Copy link
Contributor Author

saghul commented Oct 22, 2024

All good! WDYT Ben? I think it's kinda nice to put it there in the runtime state.

bnoordhuis
bnoordhuis approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now do os_pending_signals next :-)

quickjs-libc.c Outdated Show resolved Hide resolved
@saghul @bnoordhuis
Update quickjs-libc.c
c937330 
Co-authored-by: Ben Noordhuis <[email protected]>
@saghul saghul merged commit 995de25 into master Oct 22, 2024
15 checks passed
@saghul saghul deleted the libc-no-atomic branch October 22, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saghul @bnoordhuis