Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run local tests with run-test262 #591

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

bnoordhuis
Copy link
Contributor

First commit is #579.

@saghul
Copy link
Contributor

saghul commented Oct 10, 2024

Love this!

Copy link
Contributor

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! How do you want to proceed? Land this and fix run-262 later so we can run the actual suite on Windows or the other way around?

@bnoordhuis
Copy link
Contributor Author

I'll go ahead and land this because this whole exercise ultimately is so I can add an expect-fail test for #567 :-)

The ulterior motive here is not that I want to increase CI times
further but that I want to repurpose run-test262 for running our
own tests.
We always run the test262 suite in new-style mode.
@bnoordhuis bnoordhuis merged commit b9be6d4 into quickjs-ng:master Oct 10, 2024
13 checks passed
@bnoordhuis bnoordhuis deleted the local-tests branch October 10, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants