Add 'self' global #108
Closed
Add 'self' global #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you elaborate why that's necessary? |
|
No strong opinion. Other runtimes have it, and the wpt harness needed it so I thought why not? If we want to keep it simple we can drop it, I can't run the harness as-is anyway... |
You mean like V8? I'm reasonably sure it's inserted by Chromium, not V8. Node doesn't have it, for instance. It'd be fine to have qjs add it to the JSContext but I'd rather not add non-standard things in the runtime itself. |
|
I think Deno has it but you're right, let's drop it. |
|
That makes sense because deno also has a window object, although that isn't without its issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.