Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(solus): update Solus URLs #1496

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

silkeh
Copy link

@silkeh silkeh commented Oct 27, 2024

Description

The latest Solus release has changed the naming of ISOs:

  • Update all related functions to support the ISO name format used in the latest release.
  • Use the directory listings in order to support more releases in the future.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my code
  • I have tested my code in common scenarios and confirmed there are no regressions
  • I have added comments to my code, particularly in hard-to-understand sections

The latest Solus release has changed the naming of ISOs:

- Update all related functions to support the ISO name
  format used in the latest release.
- Use the directory listings in order to support more releases in the future.
@lj3954
Copy link
Member

lj3954 commented Oct 29, 2024

I think it may be a better idea to allow web_pipe to take in extra arguments for curl, rather than creating a separate function for a single header to be passed.

@philclifford
Copy link
Contributor

@lj3954 I agree that a single more flexible function would be optimal. However this works and has no impact elsewhere so could be merged to fix the immediate issue of Solus breakage and a seperate issue created to refactor the two functions into one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants