Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssh2-sftp-client update #1

Closed
wants to merge 1 commit into from

Conversation

Rishats
Copy link
Contributor

@Rishats Rishats commented Dec 24, 2021

Update ssh2-sftp-client related to concurency problem in quick-lint/quick-lint-js#491

P.S
I don't remove node_modules from repo,I think it shouldn't be in the repository. What do you think @strager ?

@strager
Copy link
Contributor

strager commented Dec 24, 2021

I don't remove node_modules from repo,I think it shouldn't be in the repository. What do you think @strager ?

node_modules is supposed to be inside the repository. GitHub Actions doesn't run npm install; it assumes the action project is ready to use after cloning. https://docs.github.com/en/actions/creating-actions/creating-a-javascript-action#commit-tag-and-push-your-action-to-github

@strager
Copy link
Contributor

strager commented Jan 4, 2022

You should commit changes to node_modules.

Additionally, you should use Yarn (v1) instead of npm. This project already has a yarn.lock file.

@strager
Copy link
Contributor

strager commented Jan 4, 2022

(Upgrading ssh2-sftp-client sounds like a good plan, by the way!)

@strager
Copy link
Contributor

strager commented Mar 2, 2023

I landed this in commit f91d9df.

@strager strager closed this Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants