Skip to content

Commit

Permalink
feat: upgrade ssh2-sftp-update dependency
Browse files Browse the repository at this point in the history
In quick-lint-js' builds, artifact uploads often fail [1]:

    note: Found 1 files to upload
    note: Uploading to remote directory: ***/builds/d32117cb896385a05fdc68c727535f5b9f3f9a33/manual/
    error: Error: _mkdir: Failure ***/builds/d32117cb896385a05fdc68c727535f5b9f3f9a33
        at fmtError (/Users/github-builder/github-actions-runner/_layout/_work/_actions/quick-lint/sftp-upload/master/node_modules/ssh2-sftp-client/src/utils.js:53:18)
        at /Users/github-builder/github-actions-runner/_layout/_work/_actions/quick-lint/sftp-upload/master/node_modules/ssh2-sftp-client/src/index.js:729:20
        at SFTPStream._transform (/Users/github-builder/github-actions-runner/_layout/_work/_actions/quick-lint/sftp-upload/master/node_modules/ssh2-streams/lib/sftp.js:417:17)
        at SFTPStream.Transform._write (node:internal/streams/transform:184:23)
        at writeOrBuffer (node:internal/streams/writable:389:12)
        at _write (node:internal/streams/writable:330:10)
        at SFTPStream.Writable.write (node:internal/streams/writable:334:10)
        at Channel.ondata (node:internal/streams/readable:754:22)
        at Channel.emit (node:events:394:28)
        at addChunk (node:internal/streams/readable:315:12)

This issue may have been fixed in ssh2-sftp-client upstream [2]. Upgrade
to get the potential fix.

The ssh2 package, used by ssh2-sftp-client, added an optional Node.js
native dependency. Make sure to not install it by running
'yarn install --ignore-optional' instead of just 'yarn install'.

[1] quick-lint/quick-lint-js#491
[2] theophilusx/ssh2-sftp-client#360

Co-Authored-By: Rishat Sultanov <[email protected]>
  • Loading branch information
strager and Rishats committed Mar 1, 2023
1 parent 813f5d0 commit f91d9df
Show file tree
Hide file tree
Showing 629 changed files with 117,165 additions and 67,189 deletions.
10 changes: 10 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,16 @@ GitHub Action to upload files to an SFTP server.
only. No stability is guaranteed or implied. Use at your own
risk.

## Updating dependencies

After changing `package.json`, run the following command:

```bash
yarn install --ignore-optional
```

Commit all changes to `node_modules/`, including added and removed files.

## Manual testing

You can test locally from a Linux machine by running the
Expand Down
1 change: 1 addition & 0 deletions node_modules/.bin/prettier

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

64 changes: 64 additions & 0 deletions node_modules/.yarn-integrity

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

26 changes: 0 additions & 26 deletions node_modules/@dabh/diagnostics/CHANGELOG.md

This file was deleted.

20 changes: 0 additions & 20 deletions node_modules/@dabh/diagnostics/LICENSE

This file was deleted.

Loading

0 comments on commit f91d9df

Please sign in to comment.