-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempts to fix issue #266 #317
Open
keyehzy
wants to merge
8
commits into
quick-lint:master
Choose a base branch
from
keyehzy:else_fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on May 18, 2021
-
We do this by treating `else (` separately. If `else` is followed by a (conditional + block) pattern, maybe the intention was to use an `else if` instead and a warning is emitted.
Configuration menu - View commit details
-
Copy full SHA for 1e1e6ab - Browse repository at this point
Copy the full SHA 1e1e6abView commit details
Commits on May 19, 2021
-
Improved code from last commit
Included function to check if the expression is side-effect-free, although I have to check more carefully if the cases are done correctly. The cases that explicitly not side-effect-free are: dot, index, function and named_functions. From testing I found that arrow functions invalidate placing an `if`, even if their children are side-effect-free. This case is treated seperately. Maybe there are more cases where this happens and I must think it through.
Configuration menu - View commit details
-
Copy full SHA for 532bc4f - Browse repository at this point
Copy the full SHA 532bc4fView commit details
Commits on May 22, 2021
-
Testing function
parser::has_potential_side_effects
This function has been refactored and tested for edge cases.
Configuration menu - View commit details
-
Copy full SHA for 8be203a - Browse repository at this point
Copy the full SHA 8be203aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 546a877 - Browse repository at this point
Copy the full SHA 546a877View commit details -
Configuration menu - View commit details
-
Copy full SHA for e17eb7c - Browse repository at this point
Copy the full SHA e17eb7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for c2d812b - Browse repository at this point
Copy the full SHA c2d812bView commit details
Commits on May 24, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 9ea9fb3 - Browse repository at this point
Copy the full SHA 9ea9fb3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a7536a - Browse repository at this point
Copy the full SHA 6a7536aView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.