Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempts to fix issue #266 #317

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Attempts to fix issue #266 #317

wants to merge 8 commits into from

Commits on May 18, 2021

  1. Attempts to fix issue #266

    We do this by treating `else (` separately. If `else` is followed by
    a (conditional + block) pattern, maybe the intention was to use an
    `else if` instead and a warning is emitted.
    keyehzy committed May 18, 2021
    Configuration menu
    Copy the full SHA
    1e1e6ab View commit details
    Browse the repository at this point in the history

Commits on May 19, 2021

  1. Improved code from last commit

    Included function to check if the expression is side-effect-free,
    although I have to check more carefully if the cases are done
    correctly.
    
    The cases that explicitly not side-effect-free are: dot, index,
    function and named_functions.
    
    From testing I found that arrow functions invalidate placing an `if`,
    even if their children are side-effect-free. This case is treated
    seperately. Maybe there are more cases where this happens and I must
    think it through.
    keyehzy committed May 19, 2021
    Configuration menu
    Copy the full SHA
    532bc4f View commit details
    Browse the repository at this point in the history

Commits on May 22, 2021

  1. Testing function parser::has_potential_side_effects

    This function has been refactored and tested for edge cases.
    keyehzy committed May 22, 2021
    Configuration menu
    Copy the full SHA
    8be203a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    546a877 View commit details
    Browse the repository at this point in the history
  3. Make tests more compact

    keyehzy committed May 22, 2021
    Configuration menu
    Copy the full SHA
    e17eb7c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c2d812b View commit details
    Browse the repository at this point in the history

Commits on May 24, 2021

  1. Improve on previous commit

    keyehzy committed May 24, 2021
    Configuration menu
    Copy the full SHA
    9ea9fb3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6a7536a View commit details
    Browse the repository at this point in the history