Open
Conversation
RFC does not require PATH_CHALLENGE frame in a first packet to new path. Instead of requiring it, verify that PATH_CHALLENGE frame is sent to new path before a packet containing non-probing packet is sent. PATH_CHALLENGE can be in a same packet that contains non-probing frame.
Because a packet that contains PATH_CHALLENGE is subject to pacing, an endpoint might not be able to send it because of pacer. Meanwhile, ACK only packet can be sent without pacing limitation as per RFC 9002, section 7.7. This means that non-probing ACK only packet may be sent before sending a packet that contains PATH_CHALLENGE. To deal with this situation, ignore ACK only packet when detecting non-probing packet in rebind-port test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC does not require PATH_CHALLENGE frame in a first packet to new path. Instead of requiring it, verify that PATH_CHALLENGE frame is sent to new path before a packet containing non-probing packet is sent. PATH_CHALLENGE can be in a same packet that contains non-probing frame.
Fixes #424