-
Notifications
You must be signed in to change notification settings - Fork 21
Add writing support #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
src/ReadStat.jl
Outdated
|
||
function handle_write!() | ||
|
||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function probably has to look something like:
function handle_!(data::Ptr, len::Int, ctx::Ptr)
io = unsafe_pointer_to_objref(ctx)
actual_data = unsafe_wrap(data, len)
write(io, actual_data)
end
…inter into readstat_begin_writing
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
===========================================
- Coverage 78.63% 58.59% -20.04%
===========================================
Files 2 2
Lines 117 157 +40
===========================================
Hits 92 92
- Misses 25 65 +40
Continue to review full report at Codecov.
|
Would probably be best to add tests as well here. Is the PR otherwise ready? |
queryverse/StatFiles.jl#1