Skip to content

Add writing support #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

TonyLianLong
Copy link
Contributor

src/ReadStat.jl Outdated

function handle_write!()

end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function probably has to look something like:

 function handle_!(data::Ptr, len::Int, ctx::Ptr)
          io = unsafe_pointer_to_objref(ctx)
          actual_data = unsafe_wrap(data, len)
          write(io, actual_data)
       end

@codecov-io
Copy link

codecov-io commented Mar 20, 2019

Codecov Report

Merging #46 into master will decrease coverage by 20.03%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #46       +/-   ##
===========================================
- Coverage   78.63%   58.59%   -20.04%     
===========================================
  Files           2        2               
  Lines         117      157       +40     
===========================================
  Hits           92       92               
- Misses         25       65       +40
Impacted Files Coverage Δ
src/ReadStat.jl 58.01% <0%> (-19.54%) ⬇️
src/C_interface.jl 61.53% <0%> (-22.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a5a55d...9f5c76e. Read the comment docs.

@andreasnoack
Copy link
Contributor

Would probably be best to add tests as well here. Is the PR otherwise ready?

@jkrumbiegel jkrumbiegel mentioned this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants