Speed up image cropping and resizing #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krikru
force-pushed
the
speed-up-image-resizing
branch
from
570fbaa to
9111635
Compare
Make the function center_crop_and_resize() support non-quadratic output shapes and crop padding shapes. The arguments image_size and crop_padding should be able to either be scalars (like they currently are) or lists or tuples containing both a height and a width.
krikru
force-pushed
the
speed-up-image-resizing
branch
from
9111635 to
3daf692
Compare
|
Hi @krikru |
krikru
force-pushed
the
speed-up-image-resizing
branch
from
3daf692 to
e6dc68c
Compare
|
I have updated my pull request. How does this code look? |
krikru
force-pushed
the
speed-up-image-resizing
branch
from
e6dc68c to
36bb0b3
Compare
To make the process of cropping and resizing images go faster, switch from the resize function in skimage.transform to the resize function in cv2 if cv2 is available on the system, otherwise stick with skimage.transform.resize.
krikru
force-pushed
the
speed-up-image-resizing
branch
from
36bb0b3 to
0defe1c
Compare
|
@qubvel I have three pending pull requests, including this one. Will they be merged? |
|
Opencv returns BGR image, while scikit-image returns RGB image, I wonder if you tested the result? |
|
@Clara85 Tested in what regard? When resizing, OpenCV only returns a BGR image if it is fed a BGR image as input; if you feed it an RGB image it will also return an RGB image (it has no way of telling whether the image is a BGR or an RGB image, and therefore won't rearrange the channel order). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.