bug: retain indentation formatting in migration script (PROJQUAY-8360) #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: harishsurf <[email protected]>
bcaton85
approved these changes
Jan 2, 2025
harishsurf
added
the
ok-to-test
|
The Jira request failed with status code 401. You can retry the check by commenting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change retains the indentation format for
manifest/ manifest listdb entries when doing an upgrade from postgres to sqlite. Without it, the manifest would be formatted changing it's content sha256 which results in incorrect sha being generated.Testing - manually verified that the change retains the original manifest json formatting