Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept OCI manifests for indexing #1099

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

hdonnay
Copy link
Member

@hdonnay hdonnay commented Oct 12, 2020

This seemed simple enough, haven't check if there are other places where we want to accept other inputs.

Still need to update the openapi reference.

@hdonnay hdonnay requested a review from ldelossa October 12, 2020 17:54
@ldelossa
Copy link
Contributor

This is cool, and I like the idea. Only question is how do we want to communicate this to user? Do we simply say "make a json post with this mime type and we'll assume you are sending an oci manifest"? whats your thoughts here.

@hdonnay
Copy link
Member Author

hdonnay commented Oct 20, 2020

Yeah, I think we'd document the acceptable input types, and control them via the content-type header. The default would be the current state of things (assume it's our manifest format).

@hdonnay hdonnay force-pushed the content-types branch 2 times, most recently from 31004c7 to 1860b52 Compare October 21, 2020 21:09
@ldelossa
Copy link
Contributor

Cool, as a caveat we will have to reject any oci manifests where either do not contain a content descriptor, or contain a content descriptor without urls.

@mieliespoor
Copy link

Any indications on when this will see progress again? Merging this will greatly improve integrations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants