Skip to content

Conversation

@jouvin
Copy link
Contributor

@jouvin jouvin commented Dec 11, 2024

The changes in this PR fix the problem identified in quattor/template-library-core#237 after the structure change of grid/OS repositories (main branch instead of one branch per major version). The problem was caused by the fact that the (obsolete) default OS version is not part of the main branch.

@jrha
Copy link
Member

jrha commented Dec 11, 2024

Ah, failing due to quattor/configuration-modules-core#1787

- Remove default version
- Make sure each test server has an entry defining its OS version
@jouvin
Copy link
Contributor Author

jouvin commented Dec 11, 2024

The remaining error is caused by quattor/configuration-modules-core#1787. I'm reluctant to workaround the problem in the affected profiles.

The problem comes from that the fact systemd/legacy/chkconfig is loaded as part of the OS configuration but no systemd unit is defined in the systemd component for some profiles, which is a valid use case.

@jouvin
Copy link
Contributor Author

jouvin commented Dec 17, 2024

@jrha the test is still failing because merging quattor/configuration-modules-core#1787 is not enough, I forgot! The test uses the configuration module templates in template-libary-core, not in the source repository (configuration-module-core). The only way to fix this failing test is to update template-library-core (components/systemd/schema) manually with the last version (or implementing the fix). Do you agree?

@jrha
Copy link
Member

jrha commented Dec 17, 2024

That does remind me that I'd like to discuss options for not having template-libary-core be a mix of manually maintained and automatically generated content.

@jrha
Copy link
Member

jrha commented Dec 17, 2024

I suppose manually fixing the schema for now is fine.

@jouvin
Copy link
Contributor Author

jouvin commented Dec 17, 2024

That does remind me that I'd like to discuss options for not having template-libary-core be a mix of manually maintained and automatically generated content.

I agree it is not ideal but I don't have any idea on how avoiding it. Except moving the manually maintained content in another repo and importing it the same way as we do for configuration module templates. But at the price that it is much more difficult to test modifications in example profiles, as we do in test-library script, as this script rely on template-library-core and it may be unnecessarily complex to try to have it merging modifications from another repo... but may be I'm missing something...

@jrha
Copy link
Member

jrha commented Dec 18, 2024

Indeed, I don't see any obviously good options.

@jrha jrha merged commit aa41ebd into quattor:main Dec 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants