Skip to content

Commit

Permalink
fix(app-vite): pin workbox-build to 7.0.x
Browse files Browse the repository at this point in the history
instead of ^7.0.0, see GoogleChrome/workbox#3357
  • Loading branch information
yusufkandemir committed Sep 30, 2024
1 parent 56d5a0a commit bcce29e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
4 changes: 3 additions & 1 deletion app-vite/lib/modes/pwa/pwa-installation.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ const nodePackager = require('../../helpers/node-packager')
const hasTypescript = require('../../helpers/has-typescript')
const { hasEslint } = require('../../helpers/has-eslint')

const defaultVersion = '^7.0.0'
// https://github.com/GoogleChrome/workbox/issues/3357
// 7.0.0 is the only current working version, but using 7.0.x in hopes of future updates
const defaultVersion = '7.0.x'

const pwaDeps = {
'workbox-core': defaultVersion,
Expand Down
4 changes: 2 additions & 2 deletions app-vite/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
"vue": "^3.0.0",
"vue-router": "^4.0.0",
"vuex": "^4.0.0",
"workbox-build": "^7.0.0"
"workbox-build": "7.0.x"
},
"peerDependencies": {
"@electron/packager": ">= 18",
Expand All @@ -108,7 +108,7 @@
"vue": "^3.2.29",
"vue-router": "^4.0.12",
"vuex": "^4.0.0",
"workbox-build": ">= 6"
"workbox-build": "^6 || 7.0.x"
},
"peerDependenciesMeta": {
"electron-builder": {
Expand Down

0 comments on commit bcce29e

Please sign in to comment.