Fix centering of SVG icon#963
Merged
juliasilge merged 1 commit intomainfrom May 5, 2026
Merged
Conversation
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Collaborator
Author
|
We'd like to get this merged and released, so we can incorporate these changes into posit-dev/positron#13343. |
cscheid
approved these changes
May 5, 2026
Member
cscheid
left a comment
cscheid
left a comment
There was a problem hiding this comment.
😱 Looks great now, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the centering of the SVG icon:
qmd.svglanguage file icon within its 16x16 viewBox. The four-quadrant disk was offset ~2 units to the right (centered at x≈10 instead of x=8), making the icon visibly lopsided when rendered.Why haven't we noticed this problem?! Because VS Code only renders
contributes.languages.iconwhen the user has no file icon theme active (File Icon Theme → None). With any active theme, including the default Seti theme or popular ones like Material Icon Theme, VS Code uses the theme's icon instead of the language contribution. Since virtually all users have a file icon theme enabled, the off-centerqmd.svgwas effectively invisible in day-to-day use.This has come to light because of changes that @dhruvisompura has been making in posit-dev/positron#13162 and related work. It turns out this is extremely noticeable when you change to a different third party file icon theme.