[Sync to prerelease] Fix profile configuration for prerelease website#1937
Merged
cderv merged 1 commit intoprereleasefrom Mar 4, 2026
Merged
[Sync to prerelease] Fix profile configuration for prerelease website#1937cderv merged 1 commit intoprereleasefrom
cderv merged 1 commit intoprereleasefrom
Conversation
* Move prerelease-subdomain from phase profiles to base/site profiles prerelease-subdomain is a site concern (which domain am I on?), not a phase concern (prerelease vs RC). Previously, the rc profile set it to empty and the prerelease profile set it to 'prerelease.', which caused the main site to link to prerelease.quarto.org during dev phase. Now the base _quarto.yml defines prerelease-subdomain as empty (links to quarto.org) and only _quarto-prerelease-docs.yml overrides it to 'prerelease.' for the prerelease site. * Fix CI to explicitly activate prerelease profile for prerelease site When CI set QUARTO_PROFILE=prerelease-docs, the profile group [rc, prerelease] auto-added rc (the group default), giving the prerelease site RC branding. Adding 'prerelease' explicitly (prerelease,prerelease-docs) satisfies the group so the default is not auto-added. This also makes the prerelease site immune to "flip to RC" commits that reorder the profile group, eliminating empty cherry-picks when those commits are auto-backported to the prerelease branch. * Document profile system in README Explain the two-layer profile architecture (phase profiles vs site profile), what each _quarto-*.yml file does, the release lifecycle, and how to preview locally with different profiles. * Add prerelease-link-subdomain for phase-aware linking to prerelease docs Blog posts on main need to link to prerelease.quarto.org during RC phase (when docs only exist there) and switch to quarto.org after release. Unlike prerelease-subdomain (site identity), this variable is phase-aware: - Default: '' (links to quarto.org) - RC profile: 'prerelease.' (docs still on prerelease site) - prerelease-docs profile: 'prerelease.' (prerelease site links to itself) (cherry picked from commit 8516589)
Collaborator
|
/deploy-preview |
Contributor
Author
📝 Preview Deployment🔍 Full site preview: https://deploy-preview-1937.quarto.org |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sync of #1932 to
prerelease.Original PR
Fix profile configuration for prerelease website
The prerelease site (prerelease.quarto.org) gets wrong values from the profile system in two ways:
CI sets
QUARTO_PROFILE=prerelease-docs, but the profile group[rc, prerelease]auto-addsrc(the group default), giving the prerelease site RC branding instead of pre-release branding.prerelease-subdomainis defined in the phase profiles (_quarto-prerelease.yml/_quarto-rc.yml), but which subdomain to use is a site concern, not a phase concern. During dev phase, the main site incorrectly links toprerelease.quarto.org.Additionally, "flip to RC" commits that reorder the profile group get auto-backported to the prerelease branch via
port-to-prerelease.yml, causing empty cherry-picks.Fix
Separate
prerelease-subdomainfrom phase variables:_quarto.ymldefinesprerelease-subdomain: ''(links to quarto.org)_quarto-prerelease-docs.ymloverrides it toprerelease._quarto-prerelease.yml,_quarto-rc.yml) no longer set itFix CI to explicitly activate the
prereleaseprofile:QUARTO_PROFILEchanges fromprerelease-docstoprerelease,prerelease-docsrcis not auto-added