Dispatch Mutiny scheduled operations using Vert.x timers when possible #51395
+307
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jponge
force-pushed
the
feat/50918-mutiny-vertx-timers-dispatch
branch
from
bed5efc to
6509d20
Compare
Contributor
|
Thank you for this improvement! Just tried it out locally and I can remove my workaround :) |
Member
Author
|
Thanks @wjglerum that's good news! I'm waiting for some CI runs to see if anything suspicious is here. |
FroMage
approved these changes
Dec 4, 2025
Member
Author
|
Thanks @FroMage It worked on my local CI |
Member
Author
|
Also ping @vietj |
geoand
approved these changes
Dec 4, 2025
cescoffier
approved these changes
Dec 4, 2025
ozangunalp
approved these changes
Dec 4, 2025
Contributor
ozangunalp
left a comment
ozangunalp
left a comment
There was a problem hiding this comment.
A small note for the ExecutorService delegation, otherwise looks good!
...ime/src/main/java/io/quarkus/vertx/core/runtime/VertxTimerAwareScheduledExecutorService.java
Outdated
Show resolved
Hide resolved
jponge
force-pushed
the
feat/50918-mutiny-vertx-timers-dispatch
branch
from
e544f81 to
da02125
Compare
This comment has been minimized.
This comment has been minimized.
Some Mutiny operations such as delaying an item, performing a retry, or generating streams from periodic ticks all require a ScheduledExecutorService. This introduces a wrapper ScheduledExecutorService that dispatches some of the operations to Vert.x timers when called from a Vert.x event-loop, offering a more natural threading mental model as well as avoiding thread hops between worker threads and event-loops. The implementation only tunes Mutiny with that Vert.x-aware wrapper ScheduledExecutorService from the quarkus-vertx extension because non-server applications might not have Vert.x available. We also introduce an artificial build item in the Mutiny extension to ensure that the Vert.x build items always execute after those from Mutiny, or else we could have cases where Mutiny re-installs a non-Vert.x aware scheduler in its own configuration. Fixes: quarkusio#50918
…areScheduledExecutorService
This is an early design refactoring leftover.
jponge
force-pushed
the
feat/50918-mutiny-vertx-timers-dispatch
branch
from
32407be to
23f9d82
Compare
jponge
added
the
triage/waiting-for-ci
This comment has been minimized.
This comment has been minimized.
Status for workflow
|
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Mutiny operations such as delaying an item, performing a retry, or generating streams
from periodic ticks all require a ScheduledExecutorService.
This introduces a wrapper ScheduledExecutorService that dispatches some of the operations
to Vert.x timers when called from a Vert.x event-loop, offering a more natural threading
mental model as well as avoiding thread hops between worker threads and event-loops.
The implementation only tunes Mutiny with that Vert.x-aware wrapper ScheduledExecutorService
from the quarkus-vertx extension because non-server applications might not have Vert.x available.
We also introduce an artificial build item in the Mutiny extension to ensure that the Vert.x build
items always execute after those from Mutiny, or else we could have cases where Mutiny re-installs
a non-Vert.x aware scheduler in its own configuration.
Unishould not move the context to an executor thread in Quarkus #50918