Skip to content

Conversation

@NickBeginner
Copy link
Contributor

This PR fixes 32936

@NickBeginner NickBeginner force-pushed the nbelcastro/issue-32936 branch from 00f29ea to 2bc8557 Compare December 1, 2025 21:31
@quarkus-bot quarkus-bot bot added the area/hibernate-orm Hibernate ORM label Dec 1, 2025
@quarkus-bot
Copy link

quarkus-bot bot commented Dec 1, 2025

/cc @gsmet (hibernate-orm)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note you'll need to update docs as well, to mention the new component types in that list:

==== Plugging in other custom components
The Quarkus extension for Hibernate ORM will automatically
inject components annotated with `@PersistenceUnitExtension` into Hibernate Search.
The annotation can optionally target a specific persistence unit with `@PersistenceUnitExtension(name = "nameOfYourPU")`.
This feature is available for the following component types:
`org.hibernate.Interceptor`::
See <<interceptors>>.
`org.hibernate.resource.jdbc.spi.StatementInspector`::
See <<statement_inspectors>>.
`org.hibernate.type.format.FormatMapper`::
See <<json_xml_serialization_deserialization>>.
`io.quarkus.hibernate.orm.runtime.tenant.TenantResolver`::
See <<multitenancy>>.
`io.quarkus.hibernate.orm.runtime.tenant.TenantConnectionResolver`::
See <<programmatically-resolving-tenants-connections>>.

Comment on lines 662 to 664
private void applyMetadataBuilderContributor() {
Object metadataBuilderContributorSetting = buildTimeSettings
.get(JpaSettings.METADATA_BUILDER_CONTRIBUTOR);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remember to deprecate the metadata build contributor, now that you're introducing an alternative.

A @Deprecated annotation + @deprecated javadoc tag there would do the trick:

Optional<@WithConverter(TrimmedStringConverter.class) String> metadataBuilderContributor();

@NickBeginner NickBeginner changed the title ISSUE-32936 | Allow plugging in Hibernate ORM's TypeContributor, FunctionContributor and AdditionalMappingContributor ISSUE-32936 | Allow plugging in Hibernate ORM's TypeContributor and FunctionContributor Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/hibernate-orm Hibernate ORM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow plugging in Hibernate ORM's TypeContributor, FunctionContributor and AdditionalMappingContributor

2 participants