Skip to content

Conversation

@yrodiere
Copy link
Member

Backport of 961d2d4

Necessary because these internals are changing in Hibernate ORM 6.6 as part of
hibernate/hibernate-orm#11227, so this dead code may not compile anymore when we upgrade to the next 6.6.

@jmartisk @gsmet assuming this compiles (meaning the code is really dead even on this branch), could this be merged?

Also, do I need to care about Quarkus 3.15? Because backporting to that branch will be more challenging.

cc @beikov

Backport of 961d2d4

Necessary because these internals are changing in Hibernate ORM
6.6 as part of
hibernate/hibernate-orm#11227,
so this dead code may not compile anymore when we upgrade to the next
6.6.
@quarkus-bot quarkus-bot bot changed the title Remove some dead code in Panache using Hibernate ORM internals [3.20] Remove some dead code in Panache using Hibernate ORM internals Nov 13, 2025
@quarkus-bot
Copy link

quarkus-bot bot commented Nov 13, 2025

/cc @aloubyansky (3.20), @gastaldi (3.20), @gsmet (3.20), @jmartisk (3.20), @rsvoboda (3.20)

@rsvoboda
Copy link
Member

Also, do I need to care about Quarkus 3.15?

I don't think so, 3.20 and 3.27 are the active LTS streams. 3.15 is history now :)

@jmartisk
Copy link
Contributor

Thanks, we will probably take this for 3.20.5

@quarkus-bot
Copy link

quarkus-bot bot commented Nov 13, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit c0fcfa8.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/smallrye-reactive-messaging-kafka/deployment

io.quarkus.smallrye.reactivemessaging.kafka.deployment.testing.KafkaDevServicesContinuousTestingTestCase.testContinuousTestingScenario2 - History

  • io.quarkus.builder.BuildException: Build failure: Build failed due to errors [error]: Build step io.quarkus.apicurio.registry.devservice.DevServicesApicurioRegistryProcessor\#startApicurioRegistryDevService threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image quay.io/apicurio/apicurio-registry-mem:2.4.2.Final at io.quarkus.apicurio.registry.devservice.DevServicesApicurioRegistryProcessor.startApicurioRegistryDevService(DevServicesApicurioRegistryProcessor.java:90) at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:732) at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856) - java.lang.RuntimeException
java.lang.RuntimeException: 
io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.apicurio.registry.devservice.DevServicesApicurioRegistryProcessor#startApicurioRegistryDevService threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image quay.io/apicurio/apicurio-registry-mem:2.4.2.Final
	at io.quarkus.apicurio.registry.devservice.DevServicesApicurioRegistryProcessor.startApicurioRegistryDevService(DevServicesApicurioRegistryProcessor.java:90)
	at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:732)
	at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856)
	at io.quarkus.builder.BuildContext.run(BuildContext.java:255)
	at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)

⚙️ MicroProfile TCKs Tests

📦 tcks/microprofile-lra

org.eclipse.microprofile.lra.tck.TckRecoveryTests.testCancelWhenParticipantIsUnavailable - History

  • Expecting the metric Compensated callback was called Expected: a value equal to or greater than <1> but: <0> was less than <1> - java.lang.AssertionError
java.lang.AssertionError: 
Expecting the metric Compensated callback was called
Expected: a value equal to or greater than <1>
     but: <0> was less than <1>
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.eclipse.microprofile.lra.tck.TckRecoveryTests.assertMetricCallbackCalled(TckRecoveryTests.java:210)
	at org.eclipse.microprofile.lra.tck.TckRecoveryTests.testCancelWhenParticipantIsUnavailable(TckRecoveryTests.java:195)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

@jmartisk
Copy link
Contributor

@rsvoboda, I'll merge this one right away so that the CI of #51216 can run properly before our next backport meeting

@jmartisk jmartisk merged commit f1d8f86 into quarkusio:3.20 Nov 27, 2025
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants