-
Notifications
You must be signed in to change notification settings - Fork 3k
[3.20] Remove some dead code in Panache using Hibernate ORM internals #51022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Backport of 961d2d4 Necessary because these internals are changing in Hibernate ORM 6.6 as part of hibernate/hibernate-orm#11227, so this dead code may not compile anymore when we upgrade to the next 6.6.
|
/cc @aloubyansky (3.20), @gastaldi (3.20), @gsmet (3.20), @jmartisk (3.20), @rsvoboda (3.20) |
I don't think so, 3.20 and 3.27 are the active LTS streams. 3.15 is history now :) |
|
Thanks, we will probably take this for 3.20.5 |
Status for workflow
|
Backport of 961d2d4
Necessary because these internals are changing in Hibernate ORM 6.6 as part of
hibernate/hibernate-orm#11227, so this dead code may not compile anymore when we upgrade to the next 6.6.
@jmartisk @gsmet assuming this compiles (meaning the code is really dead even on this branch), could this be merged?
Also, do I need to care about Quarkus 3.15? Because backporting to that branch will be more challenging.
cc @beikov