Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround Netty SSL Bouncycastle issue in native mode #46307

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Workaround Netty SSL Bouncycastle issue in native mode #46307

merged 1 commit into from
Feb 19, 2025
+116 −2

Conversation

michalvavrik
Copy link
Member

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Feb 17, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit d22295c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

sberyozkin
sberyozkin approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though worth waiting for Foivos to have a look

@michalvavrik
Copy link
Member Author

LGTM, though worth waiting for Foivos to have a look

Absolutely, and thanks.

zakkak
zakkak approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@zakkak zakkak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a BC expert, but it looks good to me. Thanks @michalvavrik !

@zakkak zakkak merged commit 540fe14 into quarkusio:main Feb 19, 2025
35 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.21 - main milestone Feb 19, 2025
@michalvavrik michalvavrik deleted the feature/fix-bc-provider-in-netty-ssl branch February 19, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sberyozkin sberyozkin sberyozkin approved these changes

@zakkak zakkak zakkak approved these changes

Assignees
No one assigned
Labels
area/native-image area/security kind/bugfix
Projects
None yet
Milestone
3.21 - main
Development

Successfully merging this pull request may close these issues.

Private key in PKCS#1 PEM format not working with gRPC in native image
3 participants
@michalvavrik @sberyozkin @zakkak