-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration tests for hibernate-reactive-oracle #46132
base: main
Are you sure you want to change the base?
Integration tests for hibernate-reactive-oracle #46132
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looking great, I just have a few comments. The main one being about CI and native tests.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments to make the build pass on Windows -- which doesn't have containers and thus cannot handle DB tests.
Essentially these tests need to be disabled by default, like in every other module, and enabled when passing -Dtest-containers
to Maven.
This comment has been minimized.
This comment has been minimized.
I am sorry about the merge commits in the PR, but I am new to open source, so I am still learning :) |
No problem. You may want to learn about rebasing: https://docs.github.com/en/get-started/using-git/about-git-rebase If you rebase your branch on |
It is getting worse, so I converted the PR to draft :) |
Do you need me to do the rebase, or are you still trying? :) |
I am still trying, but without success. If you can do it for me, that would be great! :) |
On it |
2caa357
to
3dc8fc8
Compare
Alright, I force-pushed a rebase. I must admit you got yourself in quite a situation 😅 Better avoid merge commits from the start, next time :) You can instruct git to rebase by default when pulling, instead of merging: https://coderwall.com/p/tnoiug/rebase-by-default-when-doing-git-pull FWIW, here's what I did:
I used "s" for every commit to squash everything: Got a conflict:
Solved it manually in my IDE, then:
Got another conflict:
Solved it manually in my IDE, then:
Got another conflict:
Solved it manually in my IDE, then:
Then rebase ended successfully, so I force-pushed to rewrite the git history of this branch (don't do this anywhere, but for PRs with a messy history, it's reasonable):
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
||
# Reactive config | ||
quarkus.datasource.reactive=true | ||
quarkus.datasource.reactive.url=${oracle.reactive.url} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@IvanPetkov23 I think this should have been updated to reactive-oracle.url
to match your other changes.
CI is failing because it wasn't.
Thanks for the help and the patience :) |
This comment has been minimized.
This comment has been minimized.
e2b183a
to
a3d051d
Compare
…r ITs E.g. on quarkus-reactive-oracle-client-deployment, quarkus-it-jpa-oracle. Because the current setup doesn't seem to work.
a3d051d
to
7b2a830
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a commit to fix the DB setup, because it didn't work. Also rebased on main.
It works locally, let's see how it goes on CI.
Status for workflow
|
Status | Name | Step | Failures | Logs | Raw logs | Build scan |
---|---|---|---|---|---|---|
✖ | MicroProfile TCKs Tests | Verify |
Failures | Logs | Raw logs | 🔍 |
✖ | JVM Integration Tests - JDK 17 | Build |
Failures | Logs | Raw logs | 🔍 |
✖ | JVM Integration Tests - JDK 17 Windows | Build |
Failures | Logs | Raw logs | 🔍 |
✖ | JVM Integration Tests - JDK 21 | Build |
Failures | Logs | Raw logs | 🔍 |
Full information is available in the Build summary check run.
You can consult the Develocity build scans.
Failures
⚙️ MicroProfile TCKs Tests #
- Failing: tcks/microprofile-opentelemetry
📦 tcks/microprofile-opentelemetry
✖ Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.5.2:test (tracing) on project quarkus-tck-microprofile-opentelemetry: There are test failures.
See /home/runner/work/quarkus/quarkus/tcks/microprofile-opentelemetry/target/surefire-reports-tracing for the individual test results.
See dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
⚙️ JVM Integration Tests - JDK 17 #
- Failing: integration-tests/grpc-mutual-auth
📦 integration-tests/grpc-mutual-auth
✖ io.quarkus.grpc.examples.hello.VertxHelloWorldMutualTlsEndpointTest.testRolesHelloWorldServiceUsingBlockingStub
line 47
- History - More details - Source on GitHub
java.lang.AssertionError:
Expecting actual:
"{"details":"Error id db25e0a5-7746-4fb6-a7ff-2fdf963f85cb-2, io.grpc.StatusRuntimeException: PERMISSION_DENIED","stack":"io.grpc.StatusRuntimeException: PERMISSION_DENIED\n\tat io.grpc.stub.ClientCalls.toStatusRuntimeException(ClientCalls.java:268)\n\tat io.grpc.stub.ClientCalls.getUnchecked(ClientCalls.java:249)\n\tat io.grpc.stub.ClientCalls.blockingUnaryCall(ClientCalls.java:167)\n\tat examples.GreeterGrpc$GreeterBlockingStub.sayHelloRoleAdmin(GreeterGrpc.java:218)\n\tat io.quarkus.grpc.examples.hello.HelloWorldTlsEndpoint.roleAdminHelloBlocking(HelloWorldTlsEndpoint.java:39)\n\tat io.quarkus.grpc.examples.hello.HelloWorldTlsEndpoint$quarkusrestinvoker$roleAdminHelloBlocking_cc86c151d06f4fa62f2dd8263d84cd1d912b2dcd.invoke(Unknown Source)\n\tat org.jboss.resteasy.reactive.server.handlers.InvocationHandler.handle(InvocationHandler.java:29)\n\tat io.quarkus.resteasy.reactive.server.runtime.QuarkusResteasyReactiveRequestContext.invokeH...
✖ io.quarkus.grpc.examples.hello.VertxHelloWorldMutualTlsEndpointTest.testRolesHelloWorldServiceUsingMutinyStub
line 70
- History - More details - Source on GitHub
java.lang.AssertionError:
Expecting actual:
"{"details":"Error id db25e0a5-7746-4fb6-a7ff-2fdf963f85cb-1, io.grpc.StatusRuntimeException: PERMISSION_DENIED","stack":"io.grpc.StatusRuntimeException: PERMISSION_DENIED\n\tat io.grpc.Status.asRuntimeException(Status.java:532)\n\tat io.grpc.stub.ClientCalls$StreamObserverToCallListenerAdapter.onClose(ClientCalls.java:481)\n\tat io.grpc.PartialForwardingClientCallListener.onClose(PartialForwardingClientCallListener.java:39)\n\tat io.grpc.ForwardingClientCallListener.onClose(ForwardingClientCallListener.java:23)\n\tat io.grpc.ForwardingClientCallListener$SimpleForwardingClientCallListener.onClose(ForwardingClientCallListener.java:40)\n\tat io.quarkus.grpc.runtime.supports.IOThreadClientInterceptor$1$1.lambda$onClose$3(IOThreadClientInterceptor.java:70)\n\tat io.vertx.core.impl.ContextInternal.dispatch(ContextInternal.java:270)\n\tat io.vertx.core.impl.ContextInternal.dispatch(ContextInternal.java:252)\n\tat io.vertx.core.impl.ContextIn...
⚙️ JVM Integration Tests - JDK 17 Windows #
- Failing: integration-tests/grpc-mutual-auth
📦 integration-tests/grpc-mutual-auth
✖ io.quarkus.grpc.examples.hello.VertxHelloWorldMutualTlsEndpointTest.testRolesHelloWorldServiceUsingBlockingStub
line 47
- History - More details - Source on GitHub
java.lang.AssertionError:
Expecting actual:
"{"details":"Error id 22b86e45-2abc-4d59-9c8e-3ec673340856-2, io.grpc.StatusRuntimeException: PERMISSION_DENIED","stack":"io.grpc.StatusRuntimeException: PERMISSION_DENIED\r\n\tat io.grpc.stub.ClientCalls.toStatusRuntimeException(ClientCalls.java:268)\r\n\tat io.grpc.stub.ClientCalls.getUnchecked(ClientCalls.java:249)\r\n\tat io.grpc.stub.ClientCalls.blockingUnaryCall(ClientCalls.java:167)\r\n\tat examples.GreeterGrpc$GreeterBlockingStub.sayHelloRoleAdmin(GreeterGrpc.java:218)\r\n\tat io.quarkus.grpc.examples.hello.HelloWorldTlsEndpoint.roleAdminHelloBlocking(HelloWorldTlsEndpoint.java:39)\r\n\tat io.quarkus.grpc.examples.hello.HelloWorldTlsEndpoint$quarkusrestinvoker$roleAdminHelloBlocking_cc86c151d06f4fa62f2dd8263d84cd1d912b2dcd.invoke(Unknown Source)\r\n\tat org.jboss.resteasy.reactive.server.handlers.InvocationHandler.handle(InvocationHandler.java:29)\r\n\tat io.quarkus.resteasy.reactive.server.runtime.QuarkusResteasyReactiveReques...
✖ io.quarkus.grpc.examples.hello.VertxHelloWorldMutualTlsEndpointTest.testRolesHelloWorldServiceUsingMutinyStub
line 70
- History - More details - Source on GitHub
java.lang.AssertionError:
Expecting actual:
"{"details":"Error id 22b86e45-2abc-4d59-9c8e-3ec673340856-1, io.grpc.StatusRuntimeException: PERMISSION_DENIED","stack":"io.grpc.StatusRuntimeException: PERMISSION_DENIED\r\n\tat io.grpc.Status.asRuntimeException(Status.java:532)\r\n\tat io.grpc.stub.ClientCalls$StreamObserverToCallListenerAdapter.onClose(ClientCalls.java:481)\r\n\tat io.grpc.PartialForwardingClientCallListener.onClose(PartialForwardingClientCallListener.java:39)\r\n\tat io.grpc.ForwardingClientCallListener.onClose(ForwardingClientCallListener.java:23)\r\n\tat io.grpc.ForwardingClientCallListener$SimpleForwardingClientCallListener.onClose(ForwardingClientCallListener.java:40)\r\n\tat io.quarkus.grpc.runtime.supports.IOThreadClientInterceptor$1$1.lambda$onClose$3(IOThreadClientInterceptor.java:70)\r\n\tat io.vertx.core.impl.ContextInternal.dispatch(ContextInternal.java:270)\r\n\tat io.vertx.core.impl.ContextInternal.dispatch(ContextInternal.java:252)\r\n\tat io.vertx.c...
⚙️ JVM Integration Tests - JDK 21 #
- Failing: integration-tests/grpc-mutual-auth
📦 integration-tests/grpc-mutual-auth
✖ io.quarkus.grpc.examples.hello.VertxHelloWorldMutualTlsEndpointTest.testRolesHelloWorldServiceUsingBlockingStub
line 47
- History - More details - Source on GitHub
java.lang.AssertionError:
Expecting actual:
"{"details":"Error id da41ab9e-734e-46bc-abb1-79b8c8491f7a-2, io.grpc.StatusRuntimeException: PERMISSION_DENIED","stack":"io.grpc.StatusRuntimeException: PERMISSION_DENIED\n\tat io.grpc.stub.ClientCalls.toStatusRuntimeException(ClientCalls.java:268)\n\tat io.grpc.stub.ClientCalls.getUnchecked(ClientCalls.java:249)\n\tat io.grpc.stub.ClientCalls.blockingUnaryCall(ClientCalls.java:167)\n\tat examples.GreeterGrpc$GreeterBlockingStub.sayHelloRoleAdmin(GreeterGrpc.java:218)\n\tat io.quarkus.grpc.examples.hello.HelloWorldTlsEndpoint.roleAdminHelloBlocking(HelloWorldTlsEndpoint.java:39)\n\tat io.quarkus.grpc.examples.hello.HelloWorldTlsEndpoint$quarkusrestinvoker$roleAdminHelloBlocking_cc86c151d06f4fa62f2dd8263d84cd1d912b2dcd.invoke(Unknown Source)\n\tat org.jboss.resteasy.reactive.server.handlers.InvocationHandler.handle(InvocationHandler.java:29)\n\tat io.quarkus.resteasy.reactive.server.runtime.QuarkusResteasyReactiveRequestContext.invokeH...
✖ io.quarkus.grpc.examples.hello.VertxHelloWorldMutualTlsEndpointTest.testRolesHelloWorldServiceUsingMutinyStub
line 70
- History - More details - Source on GitHub
java.lang.AssertionError:
Expecting actual:
"{"details":"Error id da41ab9e-734e-46bc-abb1-79b8c8491f7a-1, io.grpc.StatusRuntimeException: PERMISSION_DENIED","stack":"io.grpc.StatusRuntimeException: PERMISSION_DENIED\n\tat io.grpc.Status.asRuntimeException(Status.java:532)\n\tat io.grpc.stub.ClientCalls$StreamObserverToCallListenerAdapter.onClose(ClientCalls.java:481)\n\tat io.grpc.PartialForwardingClientCallListener.onClose(PartialForwardingClientCallListener.java:39)\n\tat io.grpc.ForwardingClientCallListener.onClose(ForwardingClientCallListener.java:23)\n\tat io.grpc.ForwardingClientCallListener$SimpleForwardingClientCallListener.onClose(ForwardingClientCallListener.java:40)\n\tat io.quarkus.grpc.runtime.supports.IOThreadClientInterceptor$1$1.lambda$onClose$3(IOThreadClientInterceptor.java:70)\n\tat io.vertx.core.impl.ContextInternal.dispatch(ContextInternal.java:270)\n\tat io.vertx.core.impl.ContextInternal.dispatch(ContextInternal.java:252)\n\tat io.vertx.core.impl.ContextIn...
Flaky tests - Develocity
⚙️ JVM Tests - JDK 21
📦 extensions/smallrye-reactive-messaging-kafka/deployment
✖ io.quarkus.smallrye.reactivemessaging.kafka.deployment.testing.KafkaDevServicesContinuousTestingTestCase.testContinuousTestingScenario2
- History
io.quarkus.builder.BuildException: Build failure: Build failed due to errors [error]: Build step io.quarkus.apicurio.registry.devservice.DevServicesApicurioRegistryProcessor\#startApicurioRegistryDevService threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image quay.io/apicurio/apicurio-registry-mem:2.4.2.Final at io.quarkus.apicurio.registry.devservice.DevServicesApicurioRegistryProcessor.startApicurioRegistryDevService(DevServicesApicurioRegistryProcessor.java:90) at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:733) at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856)
-java.lang.RuntimeException
java.lang.RuntimeException:
io.quarkus.builder.BuildException: Build failure: Build failed due to errors
[error]: Build step io.quarkus.apicurio.registry.devservice.DevServicesApicurioRegistryProcessor#startApicurioRegistryDevService threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image quay.io/apicurio/apicurio-registry-mem:2.4.2.Final
at io.quarkus.apicurio.registry.devservice.DevServicesApicurioRegistryProcessor.startApicurioRegistryDevService(DevServicesApicurioRegistryProcessor.java:90)
at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:733)
at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856)
at io.quarkus.builder.BuildContext.run(BuildContext.java:255)
at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)
io.quarkus.builder.BuildException: Build failure: Build failed due to errors [error]: Build step io.quarkus.apicurio.registry.devservice.DevServicesApicurioRegistryProcessor\#startApicurioRegistryDevService threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image quay.io/apicurio/apicurio-registry-mem:2.4.2.Final at io.quarkus.apicurio.registry.devservice.DevServicesApicurioRegistryProcessor.startApicurioRegistryDevService(DevServicesApicurioRegistryProcessor.java:90) at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:733) at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856)
-java.lang.RuntimeException
java.lang.RuntimeException:
io.quarkus.builder.BuildException: Build failure: Build failed due to errors
[error]: Build step io.quarkus.apicurio.registry.devservice.DevServicesApicurioRegistryProcessor#startApicurioRegistryDevService threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed for image quay.io/apicurio/apicurio-registry-mem:2.4.2.Final
at io.quarkus.apicurio.registry.devservice.DevServicesApicurioRegistryProcessor.startApicurioRegistryDevService(DevServicesApicurioRegistryProcessor.java:90)
at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:733)
at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856)
at io.quarkus.builder.BuildContext.run(BuildContext.java:255)
at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)
⚙️ Maven Tests - JDK 17
📦 integration-tests/devmode
✖ io.quarkus.test.devui.DevUIGrpcSmokeTest.testTestService
- History
Too many recursions, message not returned for id [1630720360]
-java.lang.RuntimeException
java.lang.RuntimeException: Too many recursions, message not returned for id [1630720360]
at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:164)
at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
⚙️ Native Tests - HTTP
📦 integration-tests/rest-client-reactive
✖ io.quarkus.it.rest.client.BasicTestIT.shouldCreateClientSpans
- History
expected: <1> but was: <2>
-org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: expected: <1> but was: <2>
at io.quarkus.it.rest.client.BasicTest.shouldCreateClientSpans(BasicTest.java:216)
at java.base/java.lang.reflect.Method.invoke(Method.java:569)
at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:799)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
⚙️ Native Tests - Security2
📦 integration-tests/oidc-client-wiremock
✖ io.quarkus.it.keycloak.OidcClientInGraalITCase.testGetAccessTokenWithConfiguredExpiresIn
- History
expected: <true> but was: <false>
-org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
at io.quarkus.it.keycloak.OidcClientTest.testGetAccessTokenWithConfiguredExpiresIn(OidcClientTest.java:68)
at java.base/java.lang.reflect.Method.invoke(Method.java:569)
at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:799)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
⚙️ JVM Integration Tests - JDK 17
📦 integration-tests/vertx-http
✖ io.quarkus.it.vertx.RandomTestPortTestCase.testLegacyProperties
- History
expected: <Optional[45273]> but was: <Optional.empty>
-org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: expected: <Optional[45273]> but was: <Optional.empty>
at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177)
at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1145)
at io.quarkus.it.vertx.RandomTestPortTestCase.testLegacyProperty(RandomTestPortTestCase.java:75)
⚙️ JVM Integration Tests - JDK 17 Windows
📦 integration-tests/vertx-http
✖ io.quarkus.it.vertx.RandomTestPortTestCase.testLegacyProperties
- History
expected: <Optional[63738]> but was: <Optional.empty>
-org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: expected: <Optional[63738]> but was: <Optional.empty>
at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177)
at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1145)
at io.quarkus.it.vertx.RandomTestPortTestCase.testLegacyProperty(RandomTestPortTestCase.java:75)
⚙️ JVM Integration Tests - JDK 21
📦 integration-tests/vertx-http
✖ io.quarkus.it.vertx.RandomTestPortTestCase.testLegacyProperties
- History
expected: <Optional[39715]> but was: <Optional.empty>
-org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: expected: <Optional[39715]> but was: <Optional.empty>
at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177)
at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1145)
at io.quarkus.it.vertx.RandomTestPortTestCase.testLegacyProperty(RandomTestPortTestCase.java:75)
Added tests for Hibernate Reactive with Oracle. Fixes: #23820