Module java.security.jgss should export sun.security.jgss

[gastaldi]

This enables using sun.security.jgss.SunProvider (in module java.security.jgss) which is required in quarkus-kerberos.

• See Bump to Quarkus 3.12.3 quarkiverse/quarkus-kerberos#121 (comment)

[cescoffier]

Isn't the sun package considered internal? (Mostly a question to check if this could backfire at some point)

[cescoffier]

Looks ok, but we need to verify if this sun package is internal and should not be used

[gastaldi]

Isn't the sun package considered internal? (Mostly a question to check if this could backfire at some point)

The sun.security.krb5 module above is already exported, so making that internal would require more changes

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit ab2bd29.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

---

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/amazon-lambda/deployment

✖ io.quarkus.amazon.lambda.deployment.testing.InputCollectionOutputCollectionLambdaTest.requestHandler_InputCollectionInputPerson_OutputCollectionOutputPerson - History

• 1 expectation failed. JSON path doesn't match. Expected: a collection containing map containing ["outputname"->"Fred"] Actual: <[{outputname=Chris}]> - java.lang.AssertionError

java.lang.AssertionError: 
1 expectation failed.
JSON path  doesn't match.
Expected: a collection containing map containing ["outputname"->"Fred"]
  Actual: <[{outputname=Chris}]>

	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)

---

⚙️ JVM Tests - JDK 17 Windows

📦 extensions/amazon-lambda/deployment

✖ io.quarkus.amazon.lambda.deployment.testing.InputCollectionOutputCollectionLambdaTest.requestHandler_InputCollectionInputPerson_OutputCollectionOutputPerson - History

• 1 expectation failed. JSON path doesn't match. Expected: a collection containing map containing ["outputname"->"Fred"] Actual: <[{outputname=Chris}]> - java.lang.AssertionError

java.lang.AssertionError: 
1 expectation failed.
JSON path  doesn't match.
Expected: a collection containing map containing ["outputname"->"Fred"]
  Actual: <[{outputname=Chris}]>

	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)

• 1 expectation failed. JSON path doesn't match. Expected: a collection containing map containing ["outputname"->"Chris"] Actual: <[{outputname=Fred}]> - java.lang.AssertionError

java.lang.AssertionError: 
1 expectation failed.
JSON path  doesn't match.
Expected: a collection containing map containing ["outputname"->"Chris"]
  Actual: <[{outputname=Fred}]>

	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)

[sberyozkin]

Yes, it should be ok, let me cc @zakkak for his info

[zakkak]

Yes, it should be ok, let me cc @zakkak for his info

It looks good to me but ideally the library should not use the api triggering the issue we work around with this change. I suggest opening an upstream issue about it like in pgjdbc/pgjdbc#2023