Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Disable SpringPropertiesIT in native due to upstream issue" #2306

Closed
wants to merge 1 commit into from

Conversation

rsvoboda
Copy link
Member

This reverts commit 6341c2a

quarkusio/quarkus#46172 is fixed

Summary

(Summarize the problem solved by this PR, and how to verify it manually)

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quarkusio/quarkus#46172 is fixed

thanks, had the revert on my list; failures are same so not so much fixed I guess...

@rsvoboda
Copy link
Member Author

rsvoboda commented Feb 18, 2025

Plying with reproducer from quarkusio/quarkus#46172 and it seem there is something else too, getting vvv with 999-SNAPSHOT when hitting curl -v http://localhost:8080/collections/list/strings

2025-02-18 16:17:19,156 ERROR [io.qua.ver.htt.run.QuarkusErrorHandler] (executor-thread-1) HTTP Request to /collections/list/strings failed, error id: 40d6465c-8ad8-4283-81aa-c5980763404f-1: java.lang.NullPointerException
	at [email protected]/java.util.Objects.requireNonNull(Objects.java:233)
	at [email protected]/java.lang.String.join(String.java:3571)
	at Controller.listOfStrings(Controller.java:16)
	at Controller$quarkusrestinvoker$listOfStrings_f0a20cd7878bec0bdf406f2d32316e49afe9de50.invoke(Unknown Source)
	at org.jboss.resteasy.reactive.server.handlers.InvocationHandler.handle(InvocationHandler.java:29)
	at io.quarkus.resteasy.reactive.server.runtime.QuarkusResteasyReactiveRequestContext.invokeHandler(QuarkusResteasyReactiveRequestContext.java:141)
	at org.jboss.resteasy.reactive.common.core.AbstractResteasyReactiveContext.run(AbstractResteasyReactiveContext.java:147)
	at io.quarkus.vertx.core.runtime.VertxCoreRecorder$15.runWith(VertxCoreRecorder.java:638)
	at org.jboss.threads.EnhancedQueueExecutor$Task.doRunWith(EnhancedQueueExecutor.java:2675)
	at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2654)
	at org.jboss.threads.EnhancedQueueExecutor.runThreadBody(EnhancedQueueExecutor.java:1627)
	at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1594)
	at org.jboss.threads.DelegatingRunnable.run(DelegatingRunnable.java:11)
	at org.jboss.threads.ThreadLocalResettingRunnable.run(ThreadLocalResettingRunnable.java:11)
	at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
	at [email protected]/java.lang.Thread.runWith(Thread.java:1596)
	at [email protected]/java.lang.Thread.run(Thread.java:1583)
	at org.graalvm.nativeimage.builder/com.oracle.svm.core.thread.PlatformThreads.threadStartRoutine(PlatformThreads.java:896)
	at org.graalvm.nativeimage.builder/com.oracle.svm.core.thread.PlatformThreads.threadStartRoutine(PlatformThreads.java:872)

While 3.18.3 gives Failed to load config value of type java.util.List<java.lang.String> for: lists.strings when starting the app

@rsvoboda
Copy link
Member Author

I have filed quarkusio/quarkus#46341

@rsvoboda rsvoboda closed this Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants