Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait for logs to update #2266

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Wait for logs to update #2266

merged 1 commit into from
Jan 8, 2025

Conversation

fedinskiy
Copy link
Contributor

Summary

Otherwise the test fails on Openshift

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@fedinskiy
Wait for logs to update
ae3a0c7 
Otherwise the test fails on Openshift
@fedinskiy fedinskiy requested a review from mocenas January 7, 2025 16:43
@fedinskiy fedinskiy self-assigned this Jan 7, 2025
@fedinskiy
Copy link
Contributor Author

run tests

mocenas
mocenas approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@mocenas mocenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mocenas
Copy link
Contributor

mocenas commented Jan 8, 2025

Failures in the CI are unrelated so I'm merging this.

@mocenas mocenas merged commit 256b874 into quarkus-qe:main Jan 8, 2025
7 of 9 checks passed
@fedinskiy
Copy link
Contributor Author

@mocenas failures in CI seemed related: ServerlessExtensionDockerBuildStrategyOpenShiftHttpMinimumReactiveIT.interceptedMethodFound

@fedinskiy fedinskiy deleted the fix/weekly branch January 8, 2025 08:49
@mocenas
Copy link
Contributor

mocenas commented Jan 8, 2025

@mocenas failures in CI seemed related: ServerlessExtensionDockerBuildStrategyOpenShiftHttpMinimumReactiveIT.interceptedMethodFound

Ouch, my bad, I somehow didn't connect those. Should we revert this, or is it useful anyway?

@fedinskiy
Copy link
Contributor Author

This PR fixes all opesnhift tests, except serverless ones, so it is definitely an improvement, so no need to revert.
I will investigate serverless failures, maybe we should disable this test for them completely

@fedinskiy fedinskiy mentioned this pull request Jan 9, 2025
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mocenas mocenas mocenas approved these changes

Assignees

@fedinskiy fedinskiy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fedinskiy @mocenas