-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename quarkus-qute-server-pages to quarkus-qute-web #49
Conversation
f2bc815
to
7d9b70f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good code wise, I will give it a try now
for |
That's IMO too general 🤷 . And |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok added a few comments here and there. It works like a charm :)
7d9b70f
to
0dcbf4f
Compare
- related to quarkusio/quarkus#35739 - rename the groupId from io.quarkiverse.quteserverpages to io.quarkiverse.qute.web - rename the artifactId from quarkus-qute-server-pages to quarkus-qute-web - rename the package from io.quarkiverse.quteserverpages to io.quarkiverse.qute.web - rename the config prefix from quarkus.qsp to quarkus.qute-web - rename class names with "Qsp" prefix to use the prefix "QuteWeb" - convert config to ConfigMapping - introduce new config property: web-templates-dir; defaulted to "web" - changed the default value for root-path to "/" - changed the default value for hidden-templates; no templates are hidden - rename the "qsp:" namespace to "http:"
0dcbf4f
to
31926ae
Compare
What's missing
dependencyCondition
to the core extensions.qsp:
namespace because I'm not sure ifq:
orqw:
is a better alternative? But we could change it in a follow-up PR if needed.