Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename quarkus-qute-server-pages to quarkus-qute-web #49

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Nov 10, 2023

  • related to #35739
  • rename the groupId from io.quarkiverse.quteserverpages to io.quarkiverse.qute.web
  • rename the artifactId from quarkus-qute-server-pages to quarkus-qute-web
  • rename the package from io.quarkiverse.quteserverpages to io.quarkiverse.qute.web
  • rename the config prefix from quarkus.qsp to quarkus.qute-web
  • rename class names with "Qsp" prefix to use the prefix "QuteWeb"
  • convert config to ConfigMapping
  • introduce new config property: web-templates-dir; defaulted to "web"
  • changed the default value for root-path to "/"
  • changed the default value for hidden-templates; no templates are hidden

What's missing

  1. Conditional dependencies - we need to add dependencyCondition to the core extensions.
  2. I kept the qsp: namespace because I'm not sure if q: or qw: is a better alternative? But we could change it in a follow-up PR if needed.

Copy link
Contributor

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good code wise, I will give it a try now

README.md Show resolved Hide resolved
@ia3andy
Copy link
Contributor

ia3andy commented Nov 10, 2023

for qsp: namespace replacement, why not use web:?

@mkouba
Copy link
Contributor Author

mkouba commented Nov 10, 2023

for qsp: namespace replacement, why not use web:?

That's IMO too general 🤷 . And qweb is too long. Maybe just q: or qu:?

@ia3andy
Copy link
Contributor

ia3andy commented Nov 10, 2023

for qsp: namespace replacement, why not use web:?

That's IMO too general 🤷 . And qweb is too long. Maybe just q: or qu:?

Just looked at what's available http: seems like a very good candidate:
image

@mkouba
Copy link
Contributor Author

mkouba commented Nov 10, 2023

for qsp: namespace replacement, why not use web:?

That's IMO too general 🤷 . And qweb is too long. Maybe just q: or qu:?

Just looked at what's available http: seems like a very good candidate: image

That's actually a very good point. Let's use http: then... I'll update the PR shortly.

Copy link
Contributor

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok added a few comments here and there. It works like a charm :)

- related to quarkusio/quarkus#35739
- rename the groupId from io.quarkiverse.quteserverpages to
io.quarkiverse.qute.web
- rename the artifactId from quarkus-qute-server-pages to
quarkus-qute-web
- rename the package from io.quarkiverse.quteserverpages to
io.quarkiverse.qute.web
- rename the config prefix from quarkus.qsp to quarkus.qute-web
- rename class names with "Qsp" prefix to use the prefix "QuteWeb"
- convert config to ConfigMapping
- introduce new config property: web-templates-dir; defaulted to "web"
- changed the default value for root-path to "/"
- changed the default value for hidden-templates; no templates are
hidden
- rename the "qsp:" namespace to "http:"
@mkouba mkouba merged commit 7eb31a0 into quarkiverse:main Nov 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants